Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILO entry point url and default parameters #97

Merged
merged 5 commits into from Sep 15, 2022

Conversation

ethangalebach
Copy link

fix #96

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #97 (56e9bb6) into main (56e9bb6) will not change coverage.
The diff coverage is n/a.

❗ Current head 56e9bb6 differs from pull request most recent head 6b7d627. Consider uploading reports for the commit 6b7d627 to get more accurate results

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          63       63           
  Lines        4941     4941           
=======================================
  Hits         4709     4709           
  Misses        232      232           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khaeru
Copy link
Owner

khaeru commented Aug 16, 2022

Thanks for the PR!

Both the "Lint" and Ubuntu "Test" failures are due to some things I just noticed/fixed in #98. You can click "Update branch" > "Update with rebase" to incorporate these in your PR branch. (You would also need to do git pull --rebase to mirror those changes on your local machine.)

khaeru added a commit to ethangalebach/sdmx that referenced this pull request Sep 12, 2022
@khaeru khaeru added the data-source Issues related to specific web services/data source(s) label Sep 12, 2022
@khaeru
Copy link
Owner

khaeru commented Sep 15, 2022

Okay, sorry for the noise here.

The codecov/patch check is failing because the tests that actually query every single endpoint of every supported data source are not run on every PR commit; only on a nightly schedule. So those are run, just not in this branch.

@khaeru khaeru merged commit 468c688 into khaeru:main Sep 15, 2022
@khaeru
Copy link
Owner

khaeru commented Sep 15, 2022

Thanks for the contribution!

I'll now make a release so this improvement is available on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-source Issues related to specific web services/data source(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating ILO url
2 participants