Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS target does not include source files #23

Closed
Soryu opened this issue Nov 2, 2017 · 2 comments
Closed

macOS target does not include source files #23

Soryu opened this issue Nov 2, 2017 · 2 comments

Comments

@Soryu
Copy link
Contributor

Soryu commented Nov 2, 2017

The target membership is not set on the Promise.swift and Promise+Extras.swift files. I had some issues integrating the framework via Carthage and this was one of the things I did to fix it. Makes sense to me that the files need the target membership for the mac library to work, but I might be missing something.
@khanlou
Copy link
Owner

khanlou commented Nov 2, 2017

I don't use this framework on macOS, would you consider opening PRs to fix #22 and #23?

@Soryu Soryu mentioned this issue Nov 2, 2017
Merged
@khanlou
Copy link
Owner

khanlou commented Nov 2, 2017

closing!

@khanlou khanlou closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Soryu @khanlou