Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle dark theme? #66

Open
DevHachi opened this issue Jul 7, 2023 · 5 comments
Open

How to handle dark theme? #66

DevHachi opened this issue Jul 7, 2023 · 5 comments

Comments

@DevHachi
Copy link

DevHachi commented Jul 7, 2023

First of all I like your theme switcher widget, but I got a question maybe you could point me in the right direction.

The Material App has 2 attributes theme and dark theme. (For those who doesn't have an in app switcher but switching with the system)

How could I use this library to fill both themes. As far as I can see, The ThemeProvider doesn't deliver a secondary theme or does it?

Any help would be appreciate.

@kherel
Copy link
Owner

kherel commented Jul 10, 2023

Thanks you @DevHachi for opening the issue.
I'll take a look on the next weekend.

@mllrr96
Copy link

mllrr96 commented Jul 8, 2024

@DevHachi Sorry for the reply now, I was looking for the same thing (ability to switch themes (dark and light) and theme mode) so I forked the repo and updated the package to include theme mode and dark, light theme. Also updated the examples

@kherel lmk if I should submit a pull request and thank you for the awesome package

animated_theme_switcher_v3

@kherel
Copy link
Owner

kherel commented Jul 8, 2024

@kherel lmk if I should submit a pull request and thank you for the awesome package

Sure man, go ahead.

@fredgrott
Copy link

that is some good improvements....I am going to write about it and point to that code improvement and the plugin in my substack article.

@mllrr96
Copy link

mllrr96 commented Jul 22, 2024

that is some good improvements....I am going to write about it and point to that code improvement and the plugin in my substack article.

That's lovely, pls post the link when u post it and I just submitted pull request to update it to v3

I used the updated package in my Neumorphic Calculator, I think it's a nice example showing the package so maybe you can include that in your article :) (just a suggestion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants