Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abcissas from colnames are not handled properly #5

Closed
rguliev opened this issue Jul 23, 2021 · 2 comments
Closed

Abcissas from colnames are not handled properly #5

rguliev opened this issue Jul 23, 2021 · 2 comments
Labels

Comments

@rguliev
Copy link

rguliev commented Jul 23, 2021

Here is a small example:

> x <- matrix(runif(50), ncol = 10)
> colnames(x) <- seq(420,600,length.out=10)
> x
           420       440        460       480        500       520        540       560        580       600
[1,] 0.1902495 0.6638507 0.96988143 0.4503034 0.02323665 0.7320788 0.44513545 0.5099727 0.00612236 0.9927394
...

> EMSC_model(x)
...
$abcissas
 [1]  1  2  3  4  5  6  7  8  9 10

I think the problem is in the line 144. Because is.ordered is actually related to factor variables, i.e. it always returns false for colnames.

@khliland khliland added the bug label Jul 23, 2021
@khliland
Copy link
Owner

Dear Rustam,

You are right, this is a bug in the mentioned line. Only factor colnames would be caught by the is.ordered. I will make this more general.

Regards,
Kristian

@khliland
Copy link
Owner

Corrected in version 0.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants