refact(backend-lifespan): improving type checking and incorporating lifespan as an alternative to on_event #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krr0ptioN
added
refactor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Krr0ptioN
changed the title
|
khodedawsh
reviewed
Jun 29, 2024
| if not payload.get("created_at"): | ||
| return | ||
| if dbadmin.password_reset_at > payload.get("created_at"): | ||
| if bool(dbadmin.password_reset_at): |
There was a problem hiding this comment.
no need to cast into boolean
| if db_user is User and db_user.key == key: | ||
| return db_user | ||
| else: | ||
| raise HTTPException(status_code=404, detail="User not found") |
| @@ -90,15 +89,15 @@ def get_user( | |||
| def parse_start_date(start: str | None = None): | |||
| if not start: | |||
| return datetime.fromtimestamp( | |||
| datetime.utcnow().timestamp() - 30 * 24 * 3600 | |||
| datetime.now().timestamp() - 30 * 24 * 3600 | |||
There was a problem hiding this comment.
switch back to utcnow for now so api support is not broken
There was a problem hiding this comment.
actually causes internal problem
| ) | ||
| else: | ||
| return datetime.fromisoformat(start) | ||
|
|
||
|
|
||
| def parse_end_date(end: str | None = None): | ||
| if not end: | ||
| return datetime.utcnow() | ||
| return datetime.now() |
| @@ -95,10 +95,10 @@ def modify_admin( | |||
| raise HTTPException(status_code=404, detail="Admin not found") | |||
|
|
|||
| # If a sudoer admin wants to edit another sudoer | |||
| if (username != admin.username) and dbadmin.is_sudo: | |||
| if username != admin.username and bool(dbadmin.is_sudo): | |||
There was a problem hiding this comment.
no need to cast to bool here too
| @@ -111,10 +111,10 @@ def remove_admin(username: str, db: DBDep, admin: SudoAdminDep): | |||
| if not dbadmin: | |||
| raise HTTPException(status_code=404, detail="Admin not found") | |||
|
|
|||
| if dbadmin.is_sudo: | |||
| if bool(dbadmin.is_sudo): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve few type checking errors and replacing deprecated features of Fast API with new alternative ones.
API Changes
on_eventfor graceful shutdown and disposability with lifespan.Checklist