-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Factorio Lua #141
Add Factorio Lua #141
Conversation
Added lua-factorio feature for convenience. Also custom lua-src dependency (fork)
I hope they are equivalents
Many async-related things are not available in Factorio lua, and at this point I'm not sure if I'm handling it properly.
This is not an april fools joke. Just making clear in case there was some confusion. |
I'm really sorry but I don't think it's reasonable to dissipate resources to support custom Lua forks made by game developers, considering that there are no innovations in that forks (Luau is a good example of such innovations). Also that forks simply can have severe bugs. I assume source code has not been properly auditeted and no strong community around them. Also mlua is flexible enough and allows to link to any custom Lua fork that keeps backward compatibility (non-vendored mode). |
I think I can maintain factorio lua in mlua, if you don't want to spend your own time on it. |
Wube (developers of factorio) are known for how low the amount of bugs in their game is, so the same might be translated to their lua fork. Afaik there weren't any issues caused by factorio's lua fork. The community around it is quite big, mostly mod makers. Making a separate fork which is the same with just addition of another lua in my opinion isn't good, especially while the main repo is still actively developed. If you don't want to maintain factorio lua parts, then I volunteer as a maintainer for that part. |
Closing this PR because it looks like it will not get merged |
Factorio Lua is a custom modified lua 5.2.1, used in the game Factorio.
This PR adds the ability to use Factorio lua which is available on github: https://github.com/Rseding91/Factorio-Lua
Some of the extra functionality has been added into the library. All the extra functions or changed functions are linked.
This PR also requires some modifications to
lua-src-rs
, for which I will also open a PR.