This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Improve protection against graph numbers that are actually string variables #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numeric comparisons that may involve a string (like '10' > 0 => true). But you can't call a numeric function on a string var. Our 'num' variables are *supposed* to be numbers but we have an undiscovered issue where very infrequently the number variable is a string. Until we fix that with confidence, we need to protect ourselves. This extends some previous protection to be more robust. https://issues.redhat.com/browse/OSSM-1099
jmazzitelli
reviewed
Mar 4, 2022
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
nrfox
approved these changes
Mar 7, 2022
|
Merging this, it's a pure code change and we have no recreation steps for the reported issue. Best testing is to get it into the code base. |
ghost
added this to the
jshaughn
added a commit
to jshaughn/kiali-ui
that referenced
this pull request
Mar 21, 2022
…iables (kiali#2321) * javascript is super flexible in that it actually handles things like numeric comparisons that may involve a string (like '10' > 0 => true). But you can't call a numeric function on a string var. Our 'num' variables are *supposed* to be numbers but we have an undiscovered issue where very infrequently the number variable is a string. Until we fix that with confidence, we need to protect ourselves. This extends some previous protection to be more robust. https://issues.redhat.com/browse/OSSM-1099 # Conflicts: # src/components/CytoscapeGraph/graphs/GraphStyles.ts
jshaughn
added a commit
that referenced
this pull request
Mar 21, 2022
…iables (#2321) (#2340) * javascript is super flexible in that it actually handles things like numeric comparisons that may involve a string (like '10' > 0 => true). But you can't call a numeric function on a string var. Our 'num' variables are *supposed* to be numbers but we have an undiscovered issue where very infrequently the number variable is a string. Until we fix that with confidence, we need to protect ourselves. This extends some previous protection to be more robust. Backport of #2321 https://issues.redhat.com/browse/OSSM-1099
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javascript is super flexible in that it actually handles things like
numeric comparisons that may involve a string (like '10' > 0 => true). But
you can't call a numeric function on a string var.
Our 'num' variables are supposed to be numbers but we have an undiscovered
issue where very infrequently the number variable is a string. Until we
fix that with confidence, we need to protect ourselves.
This extends some previous protection to be more robust.
https://issues.redhat.com/browse/OSSM-1099