Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable logout / add custom logout url #3934

Closed
psibi opened this issue Apr 23, 2021 · 2 comments · Fixed by kiali/kiali-ui#2162
Closed

Ability to disable logout / add custom logout url #3934

psibi opened this issue Apr 23, 2021 · 2 comments · Fixed by kiali/kiali-ui#2162
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@psibi
Copy link

psibi commented Apr 23, 2021

Is your feature request related to a problem? Please describe.

This is how my kiali setup looks like:

  • I use header authentication strategy
  • I have a SSO based setup for authentication.
  • With the header based authentication strategy, I have a logout displayed in the kiali menu.
  • Clicking the logout menu, now actually takes me to the login page of the kiali. But this is clearly wrong: Because if I do a refresh - it shows the kiali dashboard. So the logout link actually doesn't do the logout (which is fine, since it's handled by the SSO setup)

Describe the solution you'd like

There are two ways this can be solved:

  • Have the ability to disable the logout link. (Same behavior when anonymous authentication strategy is used)
  • Ability to provide custom logout link. (Similar to custom health check urls)

Describe alternatives you've considered

I have provided two alternative solutions above. I guess any one of them could solve it, although having both of them would be nice!

Additional context

No additional context needed for this issue IMO. But let me know if anything is needed.

@psibi psibi added the enhancement This is the preferred way to describe new end-to-end features. label Apr 23, 2021
@israel-hdez israel-hdez self-assigned this May 5, 2021
@israel-hdez
Copy link
Member

@psibi I think the solution will be to hide the logout option. That's what the Kubernetes Dashboard is doing, so I think we will follow that pattern.

@jshaughn jshaughn added the backlog Triaged Issue added to backlog label May 5, 2021
@psibi
Copy link
Author

psibi commented May 5, 2021

@israel-hdez Thanks, that sounds good to me. :-)

israel-hdez added a commit to israel-hdez/swsui that referenced this issue May 19, 2021
Strategies that don't support logout are anonymous and header.

Fixes kiali/kiali#3934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants