ossmc package.json did not get updated version during last build #6807
Labels
bug
Something isn't working
Comments
jmazzitelli
added a commit
to jmazzitelli/openshift-servicemesh-plugin
that referenced
this issue
Oct 31, 2023
jmazzitelli
added a commit
to kiali/openshift-servicemesh-plugin
that referenced
this issue
Nov 2, 2023
ferhoyos
added a commit
to kiali/openshift-servicemesh-plugin
that referenced
this issue
Feb 9, 2024
* fix user guide URL (#219) * Prepare for next version (#218) * Release v1.76.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * commit the change to package.json (#220) fixes: kiali/kiali#6807 * Prepare for next version (#222) * Release v1.77.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * Prepare for next version (#227) * Release v1.78.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * update of cypress and testing libraries * updated packages * cypress init setup * testing scenario to check suite is working * cypress npm script + removed package * changed naming convention * Set local Openshift Console version (#232) * Enable OSSMC plugin if no other plugins are installed in Openshift (#233) * Ensure oc login before starting plugin console (#235) * Ensure oc login before starting plugin console * Use --directory option in make Co-authored-by: John Mazzitelli <mazz@redhat.com> --------- Co-authored-by: John Mazzitelli <mazz@redhat.com> * authorization for OSSMC tests + initial smokes (#230) * update of cypress readme file * login + smokes for OSSMC * removed some boilerplate lines * enabled chromeWebSecurity * fixed readme and config baseurl * fixed comment * fixed variable name * re-enable ARM builds (#234) fixes: #192 * Cypress scenarios for setting up OSSM Console (#236) * tests for setting up ossm console * final touches for ossmc setup * fixed typos * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> --------- Co-authored-by: John Mazzitelli <mazz@redhat.com> * Copy of Kiali frontend source code (#241) Kiali frontend source originated from: * git ref: v1.73 * git commit: 05eecc1f81990aa38fa855aa400caf0398c5499a * GitHub URL: https://github.com/kiali/kiali/tree/05eecc1f81990aa38fa855aa400caf0398c5499a/frontend/src Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com> * OSSSMC sidebar tests (#242) * adding cypress:run routine + uninstall * added url for istio config * extended smoke tests for kiali pages * extended smoke tests for ossmc * newlines * fine tuning scripts * review fixes * Update plugin/cypress/e2e/featureFiles/navigation.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> --------- Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Prepare for next version (#243) * Release v1.79.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * removed all mentions of kiali-bot (#238) * Add error page when Istio Config List is not loaded correctly (#240) * Add error page when Istio Config List is not loaded correctly * Add default error message * Update plugin/src/openshift/components/ErrorPage.tsx Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> --------- Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> * Ossmc regression extended (#244) * better naming conventions * common steps refactoring * workloads smoke testing * newline * Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/workloads-deployments.ts Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/workloads-deployments.ts Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> --------- Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Generate Cypress XML report (#246) * Generate Cypress XML report * Modify prettier configuration to include cypress tests * Rename to cypress:run:junit to align with kiali repo * Update release github action (#247) * exception handling (#248) * create branch/tag of v1.73 based off of v1.76. Keeping the versions the same as the server and operator makes building all the components easier and more consistent. This commit is just a fork of the v1.76 branch, and then it changes the version strings so they show v1.73, but for all intents and purposes, v1.73 is functionally equivalent to v1.76. * we want to mimic the 1.73 z-stream from the other components (#221) * Release version 1.73.4 --------- Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com> Co-authored-by: John Mazzitelli <mazz@redhat.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> Co-authored-by: ScriptingShrimp <scriptingshrimp@protonmail.com> Co-authored-by: Pavel Marek <86114326+ScriptingShrimp@users.noreply.github.com> Co-authored-by: Tauqeer Ahmed <freelancingtwin@gmail.com> Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> Co-authored-by: Alberto Gutierrez <aljesusg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
package.json still has old version in it... our build scripts did not update it. We need to fix this for the current version and the CI workflow needs to be updated so it updates this from now on.
See the updated version showing the next version in main branch here but the version is wrong (it is the old version) in v1.76 branch
For some reason this code didn't work: https://github.com/kiali/openshift-servicemesh-plugin/blob/v1.76.0/.github/workflows/release.yaml#L188-L191
Oddly, I see the version correct in the workflow output - seems like it wasn't committed to git though: https://github.com/kiali/openshift-servicemesh-plugin/actions/runs/6692814714/job/18182753253#step:3:19
I think we are missing
plugin/package.jsonin thegit addcommand here: https://github.com/kiali/openshift-servicemesh-plugin/blob/main/.github/workflows/release.yaml#L208Should this be
git add Makefile plugin/package.jsonjust like it is on line 235?UPDATE: I think this PR will fix it, though I did not test:
The text was updated successfully, but these errors were encountered: