Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable ARM builds #234

Merged
merged 1 commit into from Jan 10, 2024
Merged

re-enable ARM builds #234

merged 1 commit into from Jan 10, 2024

Conversation

jmazzitelli
Copy link
Contributor

fixes: #192

@jmazzitelli jmazzitelli self-assigned this Jan 9, 2024
@jmazzitelli
Copy link
Contributor Author

I'm testing this via the nightly build action in my fork, and (though it is taking almost 2 hours), it looks like it is working. Follow this action and if it succeeds then we know this PR is good and we can merge it to re-enable ARM builds.

https://github.com/jmazzitelli/openshift-servicemesh-plugin/actions/runs/7463994373/job/20309956664

@jmazzitelli
Copy link
Contributor Author

Success! Action is all green here. Looks like we have ARM64 again. It took 4 hours, but you can see my fork pushed the nightly build to the "latest" tag in my quay repo here: https://quay.io/repository/jmazzitelli/ossmconsole?tab=tags (notice the 4 arches, including arm64).

So this PR is good. I will take it out of draft and ask for a review/approval.

@jmazzitelli jmazzitelli marked this pull request as ready for review January 9, 2024 20:37
ferhoyos
ferhoyos approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good and working in nightly CI workflow.

@jmazzitelli jmazzitelli merged commit 97edf67 into kiali:main Jan 10, 2024
2 checks passed
@jmazzitelli jmazzitelli deleted the bring-back-arm branch January 10, 2024 12:16
ferhoyos added a commit that referenced this pull request Feb 9, 2024
@ferhoyos @jmazzitelli
@github-actions @ScriptingShrimp @FreelancingTwin @jshaughn @aljesusg
Rebase PR from main branch to V1.73 (#249)
7ea9eb7 
* fix user guide URL (#219)

* Prepare for next version (#218)

* Release v1.76.0

* Prepare for next version

---------

Co-authored-by: kiali-bot <kiali-dev@googlegroups.com>

* commit the change to package.json (#220)

fixes: kiali/kiali#6807

* Prepare for next version (#222)

* Release v1.77.0

* Prepare for next version

---------

Co-authored-by: kiali-bot <kiali-dev@googlegroups.com>

* Prepare for next version (#227)

* Release v1.78.0

* Prepare for next version

---------

Co-authored-by: kiali-bot <kiali-dev@googlegroups.com>

* update of cypress and testing libraries

* updated  packages

* cypress init setup

* testing scenario to check suite is working

* cypress npm script + removed package

* changed naming convention

* Set local Openshift Console version (#232)

* Enable OSSMC plugin if no other plugins are installed in Openshift (#233)

* Ensure oc login before starting plugin console (#235)

* Ensure oc login before starting plugin console

* Use --directory option in make

Co-authored-by: John Mazzitelli <mazz@redhat.com>

---------

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* authorization for OSSMC tests + initial smokes  (#230)

* update of cypress readme file

* login + smokes for OSSMC

* removed some boilerplate lines

* enabled chromeWebSecurity

* fixed readme and config baseurl

* fixed comment

* fixed variable name

* re-enable ARM builds (#234)

fixes: #192

* Cypress scenarios for setting up OSSM Console (#236)

* tests for setting up ossm console

* final touches for ossmc setup

* fixed typos

* Update hack/manage-ossmc.sh

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update hack/manage-ossmc.sh

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update hack/manage-ossmc.sh

Co-authored-by: John Mazzitelli <mazz@redhat.com>

---------

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Copy of Kiali frontend source code (#241)

Kiali frontend source originated from:
* git ref:    v1.73
* git commit: 05eecc1f81990aa38fa855aa400caf0398c5499a
* GitHub URL: https://github.com/kiali/kiali/tree/05eecc1f81990aa38fa855aa400caf0398c5499a/frontend/src

Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>

* OSSSMC sidebar tests (#242)

* adding cypress:run routine + uninstall

* added url for istio config

* extended smoke tests for kiali pages

* extended smoke tests for ossmc

* newlines

* fine tuning scripts

* review fixes

* Update plugin/cypress/e2e/featureFiles/navigation.feature

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

---------

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

* Prepare for next version (#243)

* Release v1.79.0

* Prepare for next version

---------

Co-authored-by: kiali-bot <kiali-dev@googlegroups.com>

* removed all mentions of kiali-bot (#238)

* Add error page when Istio Config List is not loaded correctly (#240)

* Add error page when Istio Config List is not loaded correctly

* Add default error message

* Update plugin/src/openshift/components/ErrorPage.tsx

Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>

---------

Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>

* Ossmc regression extended (#244)

* better naming conventions

* common steps refactoring

* workloads smoke testing

* newline

* Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

* Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

* Update plugin/cypress/e2e/workloads-deployments.ts

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

* Update plugin/cypress/e2e/workloads-deployments.ts

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

---------

Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com>

* Generate Cypress XML report (#246)

* Generate Cypress XML report

* Modify prettier configuration to include cypress tests

* Rename to cypress:run:junit to align with kiali repo

* Update release github action (#247)

* exception handling (#248)

* create branch/tag of v1.73 based off of v1.76.
Keeping the versions the same as the server and operator makes
building all the components easier and more consistent.
This commit is just a fork of the v1.76 branch, and then
it changes the version strings so they show v1.73, but for all
intents and purposes, v1.73 is functionally equivalent to v1.76.

* we want to mimic the 1.73 z-stream from the other components (#221)

* Release version 1.73.4

---------

Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: kiali-bot <kiali-dev@googlegroups.com>
Co-authored-by: ScriptingShrimp <scriptingshrimp@protonmail.com>
Co-authored-by: Pavel Marek <86114326+ScriptingShrimp@users.noreply.github.com>
Co-authored-by: Tauqeer Ahmed <freelancingtwin@gmail.com>
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
Co-authored-by: Alberto Gutierrez <aljesusg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhoyos ferhoyos ferhoyos approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
Kiali Sprint 24-6 | Kiali 1.85
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-enable ARM builds
2 participants
@jmazzitelli @ferhoyos