New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OSSMC plugin if no other plugins are installed in Openshift #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazzitelli
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, lgtm
ferhoyos
added a commit
that referenced
this pull request
Feb 9, 2024
* fix user guide URL (#219) * Prepare for next version (#218) * Release v1.76.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * commit the change to package.json (#220) fixes: kiali/kiali#6807 * Prepare for next version (#222) * Release v1.77.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * Prepare for next version (#227) * Release v1.78.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * update of cypress and testing libraries * updated packages * cypress init setup * testing scenario to check suite is working * cypress npm script + removed package * changed naming convention * Set local Openshift Console version (#232) * Enable OSSMC plugin if no other plugins are installed in Openshift (#233) * Ensure oc login before starting plugin console (#235) * Ensure oc login before starting plugin console * Use --directory option in make Co-authored-by: John Mazzitelli <mazz@redhat.com> --------- Co-authored-by: John Mazzitelli <mazz@redhat.com> * authorization for OSSMC tests + initial smokes (#230) * update of cypress readme file * login + smokes for OSSMC * removed some boilerplate lines * enabled chromeWebSecurity * fixed readme and config baseurl * fixed comment * fixed variable name * re-enable ARM builds (#234) fixes: #192 * Cypress scenarios for setting up OSSM Console (#236) * tests for setting up ossm console * final touches for ossmc setup * fixed typos * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> * Update hack/manage-ossmc.sh Co-authored-by: John Mazzitelli <mazz@redhat.com> --------- Co-authored-by: John Mazzitelli <mazz@redhat.com> * Copy of Kiali frontend source code (#241) Kiali frontend source originated from: * git ref: v1.73 * git commit: 05eecc1f81990aa38fa855aa400caf0398c5499a * GitHub URL: https://github.com/kiali/kiali/tree/05eecc1f81990aa38fa855aa400caf0398c5499a/frontend/src Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com> * OSSSMC sidebar tests (#242) * adding cypress:run routine + uninstall * added url for istio config * extended smoke tests for kiali pages * extended smoke tests for ossmc * newlines * fine tuning scripts * review fixes * Update plugin/cypress/e2e/featureFiles/navigation.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> --------- Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Prepare for next version (#243) * Release v1.79.0 * Prepare for next version --------- Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> * removed all mentions of kiali-bot (#238) * Add error page when Istio Config List is not loaded correctly (#240) * Add error page when Istio Config List is not loaded correctly * Add default error message * Update plugin/src/openshift/components/ErrorPage.tsx Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> --------- Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> * Ossmc regression extended (#244) * better naming conventions * common steps refactoring * workloads smoke testing * newline * Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/featureFiles/workloads-deployments.feature Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/workloads-deployments.ts Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Update plugin/cypress/e2e/workloads-deployments.ts Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> --------- Co-authored-by: Fernando Hoyos <122779323+ferhoyos@users.noreply.github.com> * Generate Cypress XML report (#246) * Generate Cypress XML report * Modify prettier configuration to include cypress tests * Rename to cypress:run:junit to align with kiali repo * Update release github action (#247) * exception handling (#248) * create branch/tag of v1.73 based off of v1.76. Keeping the versions the same as the server and operator makes building all the components easier and more consistent. This commit is just a fork of the v1.76 branch, and then it changes the version strings so they show v1.73, but for all intents and purposes, v1.73 is functionally equivalent to v1.76. * we want to mimic the 1.73 z-stream from the other components (#221) * Release version 1.73.4 --------- Signed-off-by: Fernando Hoyos <fhoyosle@redhat.com> Co-authored-by: John Mazzitelli <mazz@redhat.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: kiali-bot <kiali-dev@googlegroups.com> Co-authored-by: ScriptingShrimp <scriptingshrimp@protonmail.com> Co-authored-by: Pavel Marek <86114326+ScriptingShrimp@users.noreply.github.com> Co-authored-by: Tauqeer Ahmed <freelancingtwin@gmail.com> Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com> Co-authored-by: Alberto Gutierrez <aljesusg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no other plugins are installed in Openshift, command
make enable-plugin
fails becauseplugin
field is not specified.This PR first creates
plugin
field if not present. Then addossmconsole
entry toplugin
field, showing a console message if the plugin is already enabled.