Bug: Miscalculation by one day

[MeirKlemp]

Hi, I recently started using your app to stop my addiction. Thank you for developing the app.

I found out that sometimes the time since last relapse is one day more than the real value.

How to reproduce the bug:

1. Create a new addiction with time later than now.
2. Go to the addictions list and look at the time since relapse of the added addiction.

Version v10.0.0

Screenshots:

[MeirKlemp]

The bug is in this function:

Sobriety/app/src/main/java/com/katiearose/sobriety/utils/Utils.kt

Line 63 in dd65f74

fun Context.convertRangeToString(start: Long, end: Long = Instant.now().toEpochMilli()): String {

If for example, a day passed but not 24 hours since the start of the addiction, then the Period will say that a day passed, even though it didn't.

I have written a fix:

val durationToEndDay = Duration.between(startDate, startDate.toLocalDate().plusDays(1).atStartOfDay(ZoneOffset.UTC))
val d = if (durationToEndDay >= duration) (period.days % 7) else (period.days % 7 - 1)

Notice that ZoneOffset.UTC should be updated according to the local ZoneOffset.

[cubandle]

Sorry about that, the patch for this issue is in process in a PR here (last commit specificially)

[MeirKlemp]

Thank for fixing it.