Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fivem Onesync Infinity Support #6

Closed
MrBluffz opened this issue Jun 12, 2021 · 8 comments
Closed

Fivem Onesync Infinity Support #6

MrBluffz opened this issue Jun 12, 2021 · 8 comments

Comments

@MrBluffz
Copy link

Is there any chance to make this chat compatible with OneSync in FiveM? All proximity based text is seen server wide.

@kibook
Copy link
Owner

kibook commented Jun 12, 2021

It's probably an issue with the IsInProximity function in client.lua.

b5fc18c adds a check whether GetPlayerFromServerId returns -1, which it apparently does if a player is out of range when using OneSync. That was being passed to GetPlayerPed, which happens to treat -1 as a shorthand for your own player ID, so if the player who sent a message was not in range it was determining proximity by comparing the distance from your own ped to... your own ped.

Let me know if that fixes it for you!

@MrBluffz
Copy link
Author

That actually appears to be working perfectly. I appreciate it!

@MrBluffz
Copy link
Author

Do you have any plans to add more functionality? Or are you satisified with it the way it is? Are you open to suggestions?

@kibook
Copy link
Owner

kibook commented Jun 13, 2021

I don't have any specific plans right now, but I will definitely be adding stuff as time goes on, and I am open to suggestions!

@MrBluffz
Copy link
Author

I run an RP server using ESX, so most of my suggestions will be FiveM/ESX specific. I am going to suggest most of the standard RP type things.

  1. Ability to set characters name. Or a config option that is true/false to use in game characters name, instead of whatever your log in name is.
  2. a /twt command with a blue border, or twitter emoji before the players name so it's clearly a tweet. Also a command in game /twthandle inserthandlehere so people can use the chat to tweet out, and have custom usernames.

Those are my suggestions for now!

@kibook
Copy link
Owner

kibook commented Jun 13, 2021

Thanks for the suggestions! I primarily run a freeroam server on RedM so RP hasn't been the main focus of this chat, although there are some things that help with RP (like proximity chat and /me actions) and I'm open to adding more things for RP.

  1. There's some work done on this already, but for the VORP framework on RedM. You can modify the GetName function to retrieve a character name rather than using the player's FiveM name. If you have an example of retrieving a character name in ESX, I can try and add "ESX" as an option for the ServerConfig.Framework setting. Otherwise I'll try and look for one when I have some time.
  2. I would like to try and make this more general or configurable, since some people use "Twitter" while others use the in-universe "Bleeter", and for RedM it would be something entirely different. Maybe just a generic "announcement" by default with the ability for server owners to label it however they like.

@MrBluffz
Copy link
Author

There is another chat mod that the owner stopped supporting, that had all of these options available, but did not support OneSync at all. It's available on Github. Would you like me to link it to you here?

@MrBluffz
Copy link
Author

Where is the best place to edit the location of the chat? I'd like to move it if possible.

@kibook kibook closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants