Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in KFH264Encoder #7

Open
koby198s opened this issue May 19, 2014 · 1 comment
Open

Memory leak in KFH264Encoder #7

koby198s opened this issue May 19, 2014 · 1 comment

Comments

@koby198s
Copy link

when set _recorder to nil, the KFH264Encoder member is not being released since there is a reference to it.
When instantiating the KFH264Encoder object (in KFH264Encoder::initWithBitrate) you pass a completion handler to _encoder.

my (simple) solution was to add a "shutdown" method to KFH264Encoder and remove the references to the completion handlers.

-(void) shutdown
{
[_encoder encodeWithBlock:nil onParams:nil];
}
call it before set _h264Encoder = nil;

this solution will free the encoder object

@chrisballinger
Copy link
Member

Ah, thanks for the bug report! This will be fixed in the next point release.

@chrisballinger chrisballinger changed the title memory leak Memory leak in KFH264Encoder May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants