Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-603: Mark as received UI inconsistent behaviour #1681

Merged
merged 2 commits into from Sep 1, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

  • load manage your pledge screen for a reward that has an estimated delivery date, and is shippable. If you reload the screen, the mark as received UI disappears. Now it has a consistent behaviour.

🤔 Why

  • A reward "no reward" is considered as such when the ID == 0 , but only for graphQL API, when the request is made to V1 API the entire the consideration of reward no reward within the backing object is reward == null && rewardId == null
  • The input data to the screen has two entry points for the reward:
    • ProjectData -> baking -> reward
    • ProjectData -> Project -> backing -> reward
      When hitting refresh the observable for showing the "Mark as received UI" was not emiting properly, now obtained both rewards if available and merged on a single observable.

👀 See

| Before 🐛 |

video_1280.mp4

| After 🦋 |

delivery_UI.mp4

| | |

📋 QA

  • Go to your profile
  • Search for a project that is completed, and a backed reward shippable
  • Load manage your pledge screen

Story 📖

SD-1527
NTV-603

@Arkariang Arkariang marked this pull request as ready for review August 30, 2022 17:11
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1681 (ef367f8) into master (5112bc8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1681   +/-   ##
=========================================
  Coverage     78.46%   78.47%           
- Complexity     1877     1878    +1     
=========================================
  Files           357      357           
  Lines         16916    16916           
  Branches       2135     2135           
=========================================
+ Hits          13273    13274    +1     
  Misses         2402     2402           
+ Partials       1241     1240    -1     
Impacted Files Coverage Δ
...ain/java/com/kickstarter/libs/utils/RewardUtils.kt 70.68% <100.00%> (ø)
app/src/main/java/com/kickstarter/models/Reward.kt 83.15% <0.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 😍

@Arkariang Arkariang merged commit f4beabd into master Sep 1, 2022
@Arkariang Arkariang deleted the imartin/NTV-603 branch September 1, 2022 15:57
Arkariang added a commit that referenced this pull request Sep 8, 2022
…ure/Android_13_Support

* 'master' of github.com:kickstarter/android-oss:
  NTV-607 : upgrade facebook sdk to latest for android 13 (#1684)
  - updated versions after release
  PAY-1893: Feature Flag Android PaymentSheet User Settings (#1682)
  WEB-665   [Android] When Facebook-only users log in to Kickstarter, require them to set a password (#1680)
  NTV-603: Mark as received UI inconsistent behaviour (#1681)

# Conflicts:
#	app/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants