Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-1893: Feature Flag Android PaymentSheet User Settings #1682

Merged
merged 5 commits into from Sep 6, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

Introducing stripe's PaymentSheet on user settings flow, in order to do it safely we are adding a new feature flag:

  • If the feature flag is on, when the user hits settings -> account -> paymentMethods, we will load PaymentMethodsSettingsActivity
  • if the feature flag is off, when the user hits settings -> account -> paymentMethods, we will load PaymentMethodsSettingsActivityLegacy

🤔 Why

  • When the user hits the button Add new card on the legacy activity the legacy cardwidget is presented
  • When the user hits the button Add new card on the non legacy screen currently nothing happens, but in future stories the PaymentSheet will be implemented.

👀 See

| Feature flag off |

FFOff.mp4

| Feature flag on |

FFOn.mp4

| --- | --- |
| | |

📋 QA

  • Turn on/off in optimizely the feature flag Android PaymentSheet User Settings
  • with the feature flag off, you should be able to add a payment source.
  • with the feature flag on, the add new card button currently has no action associated.

Story 📖

PAY-1893

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1682 (645fb0b) into master (c76dc6e) will increase coverage by 0.03%.
The diff coverage is 88.52%.

@@             Coverage Diff              @@
##             master    #1682      +/-   ##
============================================
+ Coverage     78.56%   78.59%   +0.03%     
  Complexity     1892     1892              
============================================
  Files           358      359       +1     
  Lines         17029    17089      +60     
  Branches       2145     2150       +5     
============================================
+ Hits          13378    13431      +53     
- Misses         2399     2404       +5     
- Partials       1252     1254       +2     
Impacted Files Coverage Δ
...com/kickstarter/libs/utils/extensions/IntentExt.kt 83.33% <0.00%> (-4.91%) ⬇️
...tarter/viewmodels/PaymentMethodsViewModelLegacy.kt 92.85% <92.85%> (ø)
...a/com/kickstarter/libs/models/OptimizelyFeature.kt 88.88% <100.00%> (+1.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Arkariang Arkariang marked this pull request as ready for review August 31, 2022 17:04
@Arkariang Arkariang changed the title PAY-1893: Feature flag ready PAY-1893: Feature Flag Android PaymentSheet User Settings Aug 31, 2022
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀🚀

@Arkariang Arkariang merged commit e00a7b5 into master Sep 6, 2022
@Arkariang Arkariang deleted the imartin/PAY-1893-feature-flag branch September 6, 2022 17:20
Arkariang added a commit that referenced this pull request Sep 8, 2022
…ure/Android_13_Support

* 'master' of github.com:kickstarter/android-oss:
  NTV-607 : upgrade facebook sdk to latest for android 13 (#1684)
  - updated versions after release
  PAY-1893: Feature Flag Android PaymentSheet User Settings (#1682)
  WEB-665   [Android] When Facebook-only users log in to Kickstarter, require them to set a password (#1680)
  NTV-603: Mark as received UI inconsistent behaviour (#1681)

# Conflicts:
#	app/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants