NTV-607 : upgrade facebook sdk to latest for android 13 #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Arkariang
reviewed
Sep 8, 2022
Signed-off-by: hadia <hadiamohamed.iti@gmail.com>
Arkariang
approved these changes
Sep 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
============================================
- Coverage 78.60% 78.59% -0.01%
+ Complexity 1893 1892 -1
============================================
Files 359 359
Lines 17089 17089
Branches 2150 2150
============================================
- Hits 13432 13431 -1
Misses 2404 2404
- Partials 1253 1254 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hadia
deleted the
hadia/NTV-607_upgrade_facebook_sdk_to_latest_for_android_13
branch
Arkariang
added a commit
that referenced
this pull request
Sep 8, 2022
…ure/Android_13_Support * 'master' of github.com:kickstarter/android-oss: NTV-607 : upgrade facebook sdk to latest for android 13 (#1684) - updated versions after release PAY-1893: Feature Flag Android PaymentSheet User Settings (#1682) WEB-665 [Android] When Facebook-only users log in to Kickstarter, require them to set a password (#1680) NTV-603: Mark as received UI inconsistent behaviour (#1681) # Conflicts: # app/build.gradle
Arkariang
added a commit
that referenced
this pull request
Sep 12, 2022
…tin/PAY-1895-present-payment-sheet * 'master' of github.com:kickstarter/android-oss: NTV-607 : upgrade facebook sdk to latest for android 13 (#1684) - updated versions after release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Update the Facebook sdk to latest
🤔 Why
Login with facebook stopped
🛠 How
👀 See
Before
After
device-2022-09-08-174406.mp4
device-2022-09-08-174453.mp4
📋 QA
1- test login with facebook
2- test share facebook button on thanks activity apledgeeldge project
Story 📖
NTV-607