[Enhancement] - User can see Payment Methods screen #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
reviewed
Oct 31, 2018
app/src/main/java/com/kickstarter/ui/activities/PaymentMethodsActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/PaymentMethodsViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/PaymentMethodsViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/PaymentMethodsViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/PaymentMethodsViewHolderViewModel.kt
Show resolved
Hide resolved
|
|
||
| </android.support.design.widget.AppBarLayout> | ||
|
|
||
| <ScrollView |
There was a problem hiding this comment.
Hey @dannyalright, we are wondering: should the whole screen scroll under the toolbar or only the list of cards. I'm leaning towards the list so we can always see the "Add a new card" row.
app/src/test/java/com/kickstarter/viewmodels/PaymentMethodsViewModelTest.kt
Show resolved
Hide resolved
| } | ||
| }).build()) | ||
|
|
||
| this.cards.assertValueCount(1) |
There was a problem hiding this comment.
In this test, let's assert the proper list is emitted like this:
@Test
fun testGetCards() {
val node = UserPaymentsQuery.Node("", "5555", Date(), "9876",
CreditCardState.ACTIVE, CreditCardPaymentType.CREDIT_CARD, CreditCardTypes.MASTERCARD)
setUpEnvironment(environment().toBuilder().apolloClient(object : MockApolloClient() {
override fun getStoredCards(): Observable<UserPaymentsQuery.Data> {
return Observable.just(UserPaymentsQuery.Data(UserPaymentsQuery.Me("",
UserPaymentsQuery.StoredCards("", List(1
) { _ -> node }))))
}
}).build())
this.cards.assertValue(Collections.singletonList(node))
}
}
eoji
reviewed
Nov 1, 2018
| init { | ||
| this.card.map { expiration -> expiration.expirationDate() } | ||
| .map { | ||
| val sdf = SimpleDateFormat("MM/yyyy", Locale.getDefault()) |
There was a problem hiding this comment.
Let's make this a private variable so we don't recreate it every time card emits
app/src/test/java/com/kickstarter/viewmodels/PaymentMethodsViewModelTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
PaymentMethodsViewModel,PaymentMethodsActivity,PaymentMethodsViewHolderViewModel,PaymentMethodsViewHolder, andPaymentMethodsAdapter.CreditCardTypes.PaymentMethodsViewModelandPaymentMethodsViewHolderViewModeluserpayments.graphqlfile for PaymentQueriesandMutations.CustomTypeAdapterforDate.constraint_layout_versionto1.1.3Story
User can see Payment Methods screen
See 👀