[💳] Saving credit cards #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated strings. First pass of new card screen. Does basic card validation.
…atchers to properly disable and enable save button
# Conflicts: # app/src/main/java/com/kickstarter/mock/services/MockApolloClient.kt # app/src/main/java/com/kickstarter/services/ApolloClientType.kt # app/src/main/java/com/kickstarter/services/KSApolloClient.kt # app/src/main/java/com/kickstarter/ui/activities/AccountActivity.kt
…AS and it was easier to just do it as a LinearLayout
Finished tests.
Rcureton
suggested changes
Nov 6, 2018
| } | ||
| //why wouldn't this just be an error? | ||
| val createPaymentSource = response.data()?.createPaymentSource() | ||
| if (!createPaymentSource?.isSuccessful!!) { |
There was a problem hiding this comment.
So if createPaymentSource !=null and is not successful then set the error?
app/src/main/java/com/kickstarter/viewmodels/NewCardFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/NewCardFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/NewCardFragmentViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/NewCardFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
Rcureton
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Users can now save credit cards to their account 🆒
How
MockStripeandCardFactoryclasses for testing ✨CardInputWidgetdoesn't properly tell me when it has focus or properly determine if a card is valid (IMO~)see