Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[鉁╙ Payment methods divider #393

Merged
merged 1 commit into from
Nov 29, 2018
Merged

[鉁╙ Payment methods divider #393

merged 1 commit into from
Nov 29, 2018

Conversation

eoji
Copy link
Contributor

@eoji eoji commented Nov 27, 2018

What

I noticed in @dannyalright's designs there's a really cute divider on the payment methods screen.
Also fixed the height of the button.
With tests 馃懢

no cards vs cards

@eoji eoji requested a review from Rcureton November 27, 2018 23:32
Rcureton
Rcureton approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@Rcureton Rcureton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks great also good catch 馃憖!

@dnywh
Copy link
Contributor

dnywh commented Nov 28, 2018

Nice attention to detail! Looks great

@eoji
Copy link
Contributor Author

eoji commented Nov 28, 2018

Payment methods divider

@Rcureton
Copy link
Contributor

TESTED and G2G

@eoji eoji merged commit 845b6fe into settings-v3 Nov 29, 2018
@eoji eoji deleted the io/payment-methods-divider branch November 29, 2018 15:11
@eoji eoji mentioned this pull request Feb 6, 2019
Merged
eoji added a commit that referenced this pull request Feb 6, 2019
@eoji
Settings v3 (#463)
43a2f41 
* User can see Payment Methods screen (#367)
* [馃挸] Saving credit cards (#368)
* [馃毇馃挸] Deleting saved cards (#373)
* Adding divider when cards are present with tests. (#393)
* updating stripe to 8.3.0 #453
* [馃挸] Only allowing Kickstarter accepted card types to be saved (#454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rcureton Rcureton Rcureton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eoji @dnywh @Rcureton