Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make artifactServer.port optional #59

Closed
TWiStErRob opened this issue Nov 24, 2023 · 0 comments · Fixed by #63
Closed

Make artifactServer.port optional #59

TWiStErRob opened this issue Nov 24, 2023 · 0 comments · Fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TWiStErRob
Copy link
Contributor

Feature request
artifactServer.port should allow undefined value, because act has a default for --artifact-server-port, https://github.com/nektos/act/blob/v0.2.54/cmd/root.go#L93

Additional context
I'm trying to overwrite artifactServer.path so the output is in a folder I can observe in the test. For this I have to do (testOutput returns an absolute path):

const result = await act.runEventAndJob("workflow_call", "unit-tests", {
      logFile: testOutput("act.log"),
      artifactServer: {
          path: testOutput("artifacts"),
          port: 34567 /* default: https://github.com/nektos/act/blob/v0.2.54/cmd/root.go#L93 */
      },
});

Notice that I do not need to set the port value to achieve what I want, the default would suffice.

@shubhbapna shubhbapna added good first issue Good for newcomers enhancement New feature or request labels Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants