You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
remove defining parseRunOpts as private - it's only a type definition and it would be great to be able to customize that behavior without errors
allow customizing actArguments used on parseRunOpts level
Additional context
First of all, thank you for this library 🙏
We're creating a class extending Act and right now we are overriding parseRunOpts, which is defined as private only on a .d.ts level, which causes errors, but doesn't restrict anything. I think it would be great to have more freedom in customizing how parse is done if someone decides to go further in using Act class only as a base.
I see. I am a bit hesitant on making parseRunOpts public since if someone who wants to extend Act overrides parseRunOpts but forgets to call super or conflict with some of the stuff super.parseRunOpts does, it will break Act for them.
Feature request
Either:
Additional context
First of all, thank you for this library 🙏
We're creating a class extending Act and right now we are overriding parseRunOpts, which is defined as private only on a .d.ts level, which causes errors, but doesn't restrict anything. I think it would be great to have more freedom in customizing how parse is done if someone decides to go further in using Act class only as a base.
https://github.com/Expensify/App/blob/main/workflow_tests/utils/ExtendedAct.js
The text was updated successfully, but these errors were encountered: