Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom parseRunOptions #77

Open
BrtqKr opened this issue Mar 13, 2024 · 1 comment
Open

Enable custom parseRunOptions #77

BrtqKr opened this issue Mar 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@BrtqKr
Copy link

BrtqKr commented Mar 13, 2024

Feature request
Either:

  1. remove defining parseRunOpts as private - it's only a type definition and it would be great to be able to customize that behavior without errors
  2. allow customizing actArguments used on parseRunOpts level

Additional context
First of all, thank you for this library 🙏

We're creating a class extending Act and right now we are overriding parseRunOpts, which is defined as private only on a .d.ts level, which causes errors, but doesn't restrict anything. I think it would be great to have more freedom in customizing how parse is done if someone decides to go further in using Act class only as a base.

https://github.com/Expensify/App/blob/main/workflow_tests/utils/ExtendedAct.js

@shubhbapna shubhbapna added the enhancement New feature or request label Mar 18, 2024
@shubhbapna
Copy link
Collaborator

shubhbapna commented Mar 19, 2024

I see. I am a bit hesitant on making parseRunOpts public since if someone who wants to extend Act overrides parseRunOpts but forgets to call super or conflict with some of the stuff super.parseRunOpts does, it will break Act for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants