Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x] Backport PRs for form rendering issues #2788

Merged
merged 4 commits into from Jul 27, 2022

Conversation

bxf12315
Copy link
Member

@bxf12315 bxf12315 commented Jun 14, 2022

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

https://issues.redhat.com/browse/JBPM-10058
https://issues.redhat.com/browse/JBPM-10077
https://issues.redhat.com/browse/JBPM-10077
https://issues.redhat.com/browse/JBPM-9942

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@bxf12315 bxf12315 changed the title [7.67.x] BackPort 7.13.1's issue to 7.67.x [7.67.x] BackPort 7.13.1's issues to 7.67.x Jun 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jstastny-cz
Copy link

@bxf12315 could you please add more distinctive name for the PR, e.g. [7.67.x] backport fixes for form rendering issues

@bxf12315 bxf12315 changed the title [7.67.x] BackPort 7.13.1's issues to 7.67.x [7.67.x] BackPort PRs for form rendering issues Jun 15, 2022
@bxf12315 bxf12315 changed the title [7.67.x] BackPort PRs for form rendering issues [7.67.x] Backport PRs for form rendering issues Jun 15, 2022
@bxf12315
Copy link
Member Author

@bxf12315 could you please add more distinctive name for the PR, e.g. [7.67.x] backport fixes for form rendering issues

done

@bxf12315
Copy link
Member Author

@jstastny-cz Could you please check the PR
@krisv Could you please remove donotmerge label?

Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bxf12315
Copy link
Member Author

Jenkins run fdb

Copy link

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@mareknovotny
Copy link
Member

@pefernan are you ready to approve it too?

@nmirasch nmirasch merged commit 80e3d52 into kiegroup:7.67.x Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants