Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-3579] - travel-agency example not updated to reflect infrastr… #609

Merged
merged 2 commits into from
Oct 14, 2020
Merged

[KOGITO-3579] - travel-agency example not updated to reflect infrastr… #609

merged 2 commits into from
Oct 14, 2020

Conversation

vaibhavjainwiz
Copy link
Contributor

@vaibhavjainwiz vaibhavjainwiz commented Oct 12, 2020

…ucture change

Jira issue : https://issues.redhat.com/browse/KOGITO-3579

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors' guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@kie-ci-bot kie-ci-bot bot added needs review 🔍 Pull Request that needs reviewers operator ☁️ Pull Request related to kogito-operator code base labels Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #609 into master will decrease coverage by 6.77%.
The diff coverage is 66.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   42.01%   35.23%   -6.78%     
==========================================
  Files         169      144      -25     
  Lines        9012     6956    -2056     
==========================================
- Hits         3786     2451    -1335     
+ Misses       4812     4184     -628     
+ Partials      414      321      -93     
Flag Coverage Δ
#cli 60.71% <66.99%> (+5.73%) ⬆️
#operator 27.67% <ø> (-10.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/kogito/command/remove/runtime_services.go 82.05% <ø> (-0.93%) ⬇️
cmd/kogito/command/service/build_service.go 0.00% <0.00%> (ø)
cmd/kogito/command/service/config.go 0.00% <0.00%> (ø)
cmd/kogito/command/service/runtime_service.go 0.00% <0.00%> (ø)
cmd/kogito/command/shared/default_services.go 0.00% <ø> (ø)
cmd/kogito/command/shared/install_services.go 0.00% <0.00%> (ø)
cmd/kogito/command/shared/resource_checks.go 63.29% <0.00%> (-4.53%) ⬇️
pkg/apis/app/v1alpha1/conditions.go 93.10% <ø> (+3.62%) ⬆️
pkg/apis/app/v1alpha1/kogitobuild_types.go 14.28% <ø> (-85.72%) ⬇️
pkg/apis/app/v1alpha1/kogitodataindex_types.go 12.50% <ø> (-1.79%) ⬇️
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a996be...9e91dbf. Read the comment docs.

@sutaakar
Copy link
Contributor

Also this PR should be cherrypicked to 0.16.x too

@kie-ci-bot
Copy link

kie-ci-bot bot commented Oct 12, 2020

Change detected in the PR, requesting reviews and running pipeline(if required) again

@vaibhavjainwiz
Copy link
Contributor Author

Also this PR should be cherrypicked to 0.16.x too

Once it will merge I will raise new PR to cherry-pick it in 0.16.x

@ricardozanini
Copy link
Member

/jenkins test

@sutaakar
Copy link
Contributor

/jenkins test

@ricardozanini ricardozanini added hacktoberfest hacktoberfest-accepted ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Oct 14, 2020
@ricardozanini ricardozanini added this to the v0.17.0 milestone Oct 14, 2020
@ricardozanini ricardozanini merged commit 728e7e6 into apache:master Oct 14, 2020
@vaibhavjainwiz
Copy link
Contributor Author

Also this PR should be cherrypicked to 0.16.x too

Once it will merge I will raise new PR to cherry-pick it in 0.16.x

I had raised below PR to merge into 0.16.x
#616

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest hacktoberfest-accepted operator ☁️ Pull Request related to kogito-operator code base ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants