Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If using a placeable/usable item as note, it will be used/placed as you redeem it #8

Closed
ninjakitty844 opened this issue Apr 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ninjakitty844
Copy link

ninjakitty844 commented Apr 9, 2023

Describe the bug
One example is if you use sunflower item as note (because it looks like a coin), you will place the sunflower while you redeem it. The sunflower will not drop itself as a note if you break it, luckily.

To Reproduce
Set material to sunflower, withdraw some money, place on ground.

Expected behavior
I would expect to not be able to place it, since it's money.

@Kikisito
Copy link
Owner

Hi. I'll look into it as soon as I can! I'm busy with some university tasks, sorry for any inconvenience.

@Kikisito Kikisito self-assigned this Apr 11, 2023
@Kikisito Kikisito added the bug Something isn't working label Apr 11, 2023
@Kikisito
Copy link
Owner

Kikisito commented Apr 29, 2023

This should be fixed with NFCNotes 2.3.1

https://github.com/Kikisito/NFCNotes/releases/tag/2.3.1

Please confirm if the fix works. Thanks!

@ninjakitty844
Copy link
Author

I'm guessing unfortunately there isn't a way for the client to know that it can't place the block, so it does get placed for a moment on the clients screen before being undone. But it doesn't stay, so i think it is fixed.

@Kikisito
Copy link
Owner

Kikisito commented Apr 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants