Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename columns to avoid SQL syntax error #153

Closed
reshmabidikar opened this issue Jun 29, 2023 · 2 comments
Closed

Rename columns to avoid SQL syntax error #153

reshmabidikar opened this issue Jun 29, 2023 · 2 comments
Assignees

Comments

@reshmabidikar
Copy link
Contributor

Recently, an SQL syntax error has been reported. On further investigation, it was found that the error occurs since there are some database columns named value and value is a reserved keyword. So we need to rename the value column to something else like field_value. Also see #151.

As part of this change, we will need to provide a migration file for the customers here.

We will also need to update the database migration doc. See https://github.com/killbill/technical-support/issues/16.

@pierre
Copy link
Member

pierre commented Jun 29, 2023

Note that sending /*! SET SQL_MODE=(SELECT CONCAT(@@SQL_MODE,',ANSI_QUOTES')) */; as part of the query used to do the trick to allow value as a column name in the queries, but this does not always work anymore (e.g., on latest Aurora RDS).

@reshmabidikar reshmabidikar self-assigned this Jul 5, 2023
@reshmabidikar
Copy link
Contributor Author

Addressed in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants