1615 invoice part 5 #1693
1615 invoice part 5 #1693
Conversation
This is 5th part and last PR of killbill-invoice work for 1615.
util/src/main/java/org/killbill/billing/util/collect/SimpleHashBiMap.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/killbill/billing/invoice/usage/TestContiguousIntervalConsumableInArrear.java
Show resolved
Hide resolved
|
@pierre @sbrossie I got the same problem as previous PR here. |
|
I've restarted the job. Could you create a GitHub issue with the details, so that we don't forget to investigate the source of the flakiness? |
|
@pierre this is the new issue about this. |
There was a problem hiding this comment.
It looks like BiMap and its new implementation SimpleHashBiMap is only referenced once from the MockInvoiceDao - is this accurate? The MockInvoiceDao probably manages very few entries for a couple of tests and so do we really need this additional complexity, i/e couldn't we we just have the MockInvoiceDao reverse the map when needed ?
… value See this comment: killbill#1693 (review) The method to find key by value is getAccountIdByRecordId()
|
@sbrossie yeah I think I agree with you. I just delete |
|
@sbrossie @pierre Same problem as described in #1694 . I added new comment about my observation. |
TestEntitlement#testCreateSubscriptionBillingInThePast() will assert subscription's attributes except for chargedThroughDate. See also comment in TestEntitlement#verifyChargedThroughDate()
Last PR for
killbill-invoice. Most of work is Guava to stream, except addingBiMapand itsSimpleHashBiMapimplementation. Decided to implements simple implementation because forking google BiMap implementation require a lot of Guava's classes to added as well.I think what I've done cover all basic requirement of BiMap, there's test case for it, and also I have gist for comparing with Guava's version.