Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1615 invoice part 5 #1693

Merged
merged 8 commits into from May 18, 2022
Merged

1615 invoice part 5 #1693

merged 8 commits into from May 18, 2022

Commits on May 16, 2022

  1. update FIXME description

    @xsalefter
    xsalefter committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e4e2386 View commit details
    Browse the repository at this point in the history

  2. add BiMap and its implementation

    @xsalefter
    xsalefter committed May 16, 2022
    Configuration menu
    Copy the full SHA
    d8c5dee View commit details
    Browse the repository at this point in the history

  3. replace Guava and Guice usage with stream API and JSR-330 in kb-invoice 

    This is 5th part and last PR of killbill-invoice work for 1615.
    @xsalefter
    xsalefter committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ef7e236 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. update SimpleHashBiMap implementation to handle forcePut() properly

    @xsalefter
    xsalefter committed May 17, 2022
    Configuration menu
    Copy the full SHA
    71ea890 View commit details
    Browse the repository at this point in the history

  2. re-add comment for TEST_ROLLED_UP_FIRST_USAGE_COMPARATOR

    @xsalefter
    xsalefter committed May 17, 2022
    Configuration menu
    Copy the full SHA
    daf5215 View commit details
    Browse the repository at this point in the history

  3. add warning to SimpleHashBiMap for production/large data set usage

    @xsalefter
    xsalefter committed May 17, 2022
    Configuration menu
    Copy the full SHA
    c03af94 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. delete BiMap and its implementation and use method to find map key by… 

    … value

See this comment: killbill#1693 (review) The method to find key by value is getAccountIdByRecordId()
    @xsalefter
    xsalefter committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4efeaa6 View commit details
    Browse the repository at this point in the history

  2. do not rely on object equality when asserting subscription 

    TestEntitlement#testCreateSubscriptionBillingInThePast() will assert subscription's attributes except for chargedThroughDate. See also comment in TestEntitlement#verifyChargedThroughDate()
    @xsalefter
    xsalefter committed May 18, 2022
    Configuration menu
    Copy the full SHA
    081c08c View commit details
    Browse the repository at this point in the history