Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cargo_metadata from 0.5.6 to 0.5.8 #224

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps cargo_metadata from 0.5.6 to 0.5.8.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [cargo_metadata](https://github.com/oli-obk/cargo_metadata) from 0.5.6 to 0.5.8.
- [Release notes](https://github.com/oli-obk/cargo_metadata/releases)
- [Commits](https://github.com/oli-obk/cargo_metadata/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@killercup
Copy link
Owner

@ordian, @bjgill, I just enabled dependabot for this repo to test it. Since cargo-edit is a binary crate, it makes sense to regularly update our dependencies to their latest patch versions.

This is quite a bit of noise initially (sorry!), and I'll merge these first PRs today.

I can set this up to {update all, update security-relevant patches} ⨉ {"live", daily, weekly, monthly}. I've also set it to only update the lock file -- we should do regular version bumps manually anyway. What do you think is a good setting? At first I set it to "all", "monthly" (which these PRs are from), but I think "security patches", "daily" is a better choice.

@ordian
Copy link
Collaborator

ordian commented Jul 23, 2018

@killercup I don't have a strong opinion on this. How does it determine "security patches", via advisory-db (in that case I think it's gonna be silent for quite a while). Your initial choice sounds reasonable to me.

@bjgill
Copy link
Collaborator

bjgill commented Jul 23, 2018

Interesting. I wasn't previously aware of dependabot. Seems like a sensible idea.

I could see advantages to both all monthly and security patches daily. It's a pity we can't have both simultaneously, perhaps. Given that the rate of additions to advisory-db is low, it might be that monthly all is good enough to get vulnerability fixes in a vaguely timely fashion. I don't have strong feelings about this question, though.

@killercup
Copy link
Owner

How does it determine "security patches", via advisory-db (in that case I think it's gonna be silent for quite a while).

Yeah, https://dependabot.com/rust.html says it "checks your dependencies against the RustSec Advisory Database".

It's a pity we can't have both simultaneously, perhaps.

I opened an issue with them: dependabot/feedback#102

@killercup
Copy link
Owner

From <dependabot/feedback#102>:

For security updates we always create the PRs immediately (because we can't imagine a use case where you wouldn't want that), so Dependabot should do exactly what you want with that setup.

So I've set it to monthly :)

@killercup killercup mentioned this pull request Aug 1, 2018
bors bot added a commit that referenced this pull request Aug 1, 2018
230: Upgrade deps r=killercup a=killercup

Contains #225 and #229 and closes all other dependabot PRs

Closes #220
Closes #221 
Closes #222 
Closes #223 
Closes #224 
Closes #226
Closes #227
Closes #228

Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: dependabot[bot] <support@dependabot.com>
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
@bors bors bot closed this in #230 Aug 1, 2018
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/cargo/cargo_metadata-0.5.8 branch August 1, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants