Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions and hpc data directory for Cabal 1.22 / GHC 7.10 #38

Closed
killy971 opened this issue Jan 29, 2015 · 2 comments
Closed

Fix instructions and hpc data directory for Cabal 1.22 / GHC 7.10 #38

killy971 opened this issue Jan 29, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@killy971
Copy link
Owner

Background

Starting from Cabal 1.22 / GHC 7.10, the hpc data output directory seems to have changed.
Instead of dist/hpc/, the data files are now located under dist/hpc/vanilla/.
Therefore, using hpc-coveralls up to version 0.8.3 fails when it tries to read the tix/mix files.

Implementation

The logic determining where to look for tix/mix files should be backward compatible with ghc version prior to 7.10.

It would also be a good idea to confirm whether the new directory is always dist/hpc/vanilla/ or if it can vary based on other options.

Notes

Refer to this build for failure messages when using hpc-coveralls 0.8.3: https://travis-ci.org/guillaume-nargeot/hpc-coveralls-testing2/builds/48762965

Feature branch: https://github.com/guillaume-nargeot/hpc-coveralls/tree/hpc-vanilla-directory

@killy971
Copy link
Owner Author

killy971 commented Feb 5, 2015

Reading of tix/mix files fixed as of e1fc46c

@killy971 killy971 added this to the v0.8.4 milestone Feb 6, 2015
@killy971 killy971 changed the title Fix instructions and hpc data directory for GHC 7.10 Fix instructions and hpc data directory for Cabal 1.22 / GHC 7.10 Feb 6, 2015
@killy971 killy971 closed this as completed Feb 6, 2015
@killy971
Copy link
Owner Author

killy971 commented Feb 7, 2015

Regarding the change from --enable-library-coverage to --enable-coverage, refer to this issue: haskell/cabal#1945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant