Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme is unclear regarding the meaning of the lines "Data", "none", etcetera. #9

Closed
ProBackup-nl opened this issue Dec 22, 2017 · 4 comments

Comments

@ProBackup-nl
Copy link

# compsize /mnt/sda2/Backups.backupdb/d2/2017-12-17-211627
Processed 24766 files, 20583 regular extents (22801 refs), 12848 inline.
Type       Perc     Disk Usage   Uncompressed Referenced
Data        31%      471M         1.4G         1.7G
none       100%      126M         126M         126M
zstd        25%      344M         1.3G         1.5G

Now I am wondering: what is "Data", "none" and "zstd"?
Or what are the differences between them.

After reading https://github.com/kilobyte/compsize/blob/master/README.md the clue is still missing.

@kilobyte
Copy link
Owner

The man page has a more detailed explanation, but you're right, as README mentions all other fields, it should say what's "Type" as well.

I added a line, is this enough?

@ProBackup-nl
Copy link
Author

ProBackup-nl commented Dec 22, 2017

Even after reading https://github.com/kilobyte/compsize/blob/master/compsize.8 it is still not clear to me what "Data" and "none" are.

It feels like "none" means "not compressed". Then 100% is redundant for that line.
Also redundant is the column header "Perc" and value "..%" -> "C.ratio" (value=1-current printed %)), and "Type" means "Compression type".

Still no clue what "compression type = Data" means.

@kilobyte
Copy link
Owner

kilobyte commented Dec 22, 2017

It feels like "none" means "not compressed". Then 100% is redundant for that line.

Yeah, 100% is redundant, but a table looks better with this. A different placeholder such as -- or N/A wouldn't probably be an improvement.

Still no clue what "compression type = Data" means.

What about "TOTAL", in all caps, to mark it apart from rows it's a sum of?

@ProBackup-nl
Copy link
Author

When "Data" is a total, it at least be at the bottom, below the lines it sums.
Preferably marked by a dashed line:

Type       Ratio     Disk Usage   Uncompressed Referenced
none          0%     1.4G         1.4G         1.7G
zstd         57%     574K         1.2M         1.2M
---------  -----  -------      -------      -------
total         1%     1.4G         1.4G         1.7G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants