Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sheet,popover 컴포넌트 추가 요청 #8

Closed
gitaeks opened this issue May 15, 2016 · 5 comments
Closed

sheet,popover 컴포넌트 추가 요청 #8

gitaeks opened this issue May 15, 2016 · 5 comments

Comments

@gitaeks
Copy link
Member

gitaeks commented May 15, 2016

@kieregh 님, popup 컨포넌트와 유사하게 sheet,popover 컨포넌트를 rc-component.js 에 각각 추가 요청합니다.

popup 클래스를 각각 sheet와 popover 로 치환 적용해 주면됩니다.

@kieregh
Copy link
Collaborator

kieregh commented May 16, 2016

popover 는 이미 되어 있는데요.....아래 샘플입니다.
http://www.withconsumer.net/rc-test/popover/static.html

sheet 마크업 샘플 주신다고 하셔서 대기하고 있습니다.

@gitaeks
Copy link
Member Author

gitaeks commented May 16, 2016

popover는 확인했습니다. 같은 방식으로 sheet도 추가 요청합니다.

@kieregh
Copy link
Collaborator

kieregh commented May 16, 2016

아래와 같이 sheet 추가했습니다.
f9ca6cf

@gitaeks
Copy link
Member Author

gitaeks commented May 16, 2016

sheet에서
<div class="backdrop"></div> 의 위치가 본문상에 표시 됩니다. </body> 직전에 표시될수 있도록 해주세요.

@gitaeks
Copy link
Member Author

gitaeks commented May 16, 2016

popover에서 활성화시 적용되는 클래스를 아래와 같이 수정요청합니다.

  1. 활성 상태 클래스를 visible --> active 변경
  2. rb-bottom 클래스 삭제

@gitaeks gitaeks closed this as completed May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants