Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkg-config config? #44

Closed
dimpase opened this issue Nov 16, 2021 · 5 comments
Closed

add pkg-config config? #44

dimpase opened this issue Nov 16, 2021 · 5 comments

Comments

@dimpase
Copy link

dimpase commented Nov 16, 2021

To facilitate things for non-cmake setups, such as checking the version, setting include and library paths, it would be great to have primecount generating configuration, a .pc file, and installing it in the appropriate location (often it's subdirectory pkgconfig of the directory where the library is installed).

@dimpase
Copy link
Author

dimpase commented Nov 16, 2021

@kimwalisch
Copy link
Owner

If you submit a merge request I will gladly merge it. I don't frequently use pkg-config myself, so I would appreciate if you would do the testing.

I guess you could copy/resue most of primesieve's code: primesieve.pc.in and CMakeLists.txt.

kimwalisch added a commit that referenced this issue Nov 20, 2021
@kimwalisch
Copy link
Owner

Tested successfully on Linux and macOS using both GCC & Clang.

@dimpase
Copy link
Author

dimpase commented Nov 21, 2021

Thanks. Do you have timeline for the release of 7.2 ? I know that Debian people are now busy packaging 7.1, perhaps they could wait a bit?

@kimwalisch
Copy link
Owner

Thanks. Do you have timeline for the release of 7.2 ? I know that Debian people are now busy packaging 7.1, perhaps they could wait a bit?

Yes, personally I think they should wait (and not package 7.1), this way they don't have to do the packaging work twice. I will do a new primesieve and primecount release mid next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants