Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong zoomed image position from fixed container #34

Closed
artaommahe opened this issue May 8, 2017 · 4 comments
Closed

Wrong zoomed image position from fixed container #34

artaommahe opened this issue May 8, 2017 · 4 comments

Comments

@artaommahe
Copy link

artaommahe commented May 8, 2017

I see an issue in page:
https://codepen.io/anon/pen/eWyEGR?editors=1010

OS: Ubuntu 16.04 (64-bit)
Browser and version: Chromium Version 58.0.3029.81

Steps to reproduce:

  1. open codepen example
  2. scroll one screen down
  3. zoom image
  4. see that it has wrong position

Use-case: fixed chat container with images in messages that can be zoomed when page is scrolled down.
Mb fixed position for zoomed image?

@kingdido999 kingdido999 added the bug label May 8, 2017
@kingdido999
Copy link
Owner

I probably will end up adding a fixed wrapper to image, which I believe will address this issue and #22 as well...Having position: relative on image is giving me so much headache :(

@kingdido999
Copy link
Owner

Update: a fixed position wrapper with absolute image position and an image placeholder (since the actual image no longer takes space) does resolve these issues (position: fixed and overflow: hidden parents). Everything works fine except that while the image is getting closed on scrolling, the translation does not go to the precise position that takes scroll offset into account (though eventually it goes back to the correct position...). I guess this could be fixed somehow, but I haven't found a solution yet.

@kingdido999 kingdido999 changed the title (bug) Wrong zoomed image position from fixed container Wrong zoomed image position from fixed container Jun 24, 2017
@kingdido999
Copy link
Owner

Opened an issue to keep track of adding image wrapper #44.

@kingdido999
Copy link
Owner

I don't intend to find a fix at this point. I'll accept it as a known issue and mention it in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants