Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @nonlinear_form functionality and modify example #27

Closed
kinnala opened this issue Aug 9, 2018 · 1 comment
Closed

Remove @nonlinear_form functionality and modify example #27

kinnala opened this issue Aug 9, 2018 · 1 comment

Comments

@kinnala
Copy link
Owner

kinnala commented Aug 9, 2018

I tried extending @nonlinear_form to vectorial elements and solved St. Venant-Kirchhoff hyperelastic problem. The resulting code, evaluation of the Jacobian using autograd, turned out to be so slow that it was basically unusable. Unless we have a good alternative to autograd, I think this functionality is unnecessary: the user can always compute Jacobian by hand and use @bilinear_form and @linear_form which results in a faster implementation.

Since I think we should focus on the core functionality of the library, I propose that we remove @nonlinear_form altogether and modify ex10.py so that the Jacobian is computed symbolically.

@kinnala
Copy link
Owner Author

kinnala commented Aug 9, 2018

This was done in 75afe58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant