Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make collapse/expand all/parent only more discoverable #191

Closed
raveren opened this issue Apr 18, 2016 · 5 comments
Closed

Make collapse/expand all/parent only more discoverable #191

raveren opened this issue Apr 18, 2016 · 5 comments
Assignees

Comments

@raveren
Copy link
Contributor

raveren commented Apr 18, 2016

see #69

@benjamw
Copy link

benjamw commented Feb 22, 2017

One thing that may help in discoverability is to have the cursor change to a pointer when hovering the clickable var name and then have a title on that that says something like "Open/close current level". And put a title on the arrow/plus/whatever that says "Open/Close all children".

But for me... Clicking the arrow/plus/whatever should only open the current level, and then clicking the name should be the open everything action. So basically reversed.

@jnvsor
Copy link
Member

jnvsor commented Feb 22, 2017

So whenever you want to copy paste, whenever you misclick, or whenever you just randomly click on kint it'll open everything at once? Sounds like a bad idea to me.

@benjamw
Copy link

benjamw commented Feb 23, 2017

Well... making the whole header clickable is a bad idea. I'm just saying that the default "open" action seems like it should be "open one" and not "open all". Especially with huge array or object trees.

@jnvsor jnvsor self-assigned this Mar 9, 2017
@jnvsor
Copy link
Member

jnvsor commented Mar 9, 2017

Perhaps moving "open all" to doubleclick and "open everything" to tripleclick would be the best option. I'll look into it

@jnvsor
Copy link
Member

jnvsor commented Mar 11, 2017

This should be fixed in 2.x as of a324bd7 - I've gone ahead and bumped the doubleclick to a tripleclick as explained in my last comment

@benjamw Feel free to test and leave feedback at #208

@jnvsor jnvsor closed this as completed Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants