Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support npm script to fix lint error for all packages #1843

Closed
1 task
hung-cybo opened this issue Nov 16, 2022 · 0 comments · Fixed by #1869
Closed
1 task

Support npm script to fix lint error for all packages #1843

hung-cybo opened this issue Nov 16, 2022 · 0 comments · Fixed by #1869
Assignees
@hung-cybo
Labels
pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: data-loader @kintone/data-loader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-packer @kintone/plugin-packer pkg: plugin-uploader @kintone/plugin-uploader pkg: profile-loader @kintone/profile-loader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin

Comments

@hung-cybo
Copy link
Contributor

Package

  • @kintone/create-plugin
  • @kintone/customize-uploader
  • @kintone/dts-gen
  • @kintone/plugin-manifest-validator
  • @kintone/plugin-packer
  • @kintone/plugin-uploader
  • @kintone/profile-loader
  • @kintone/rest-api-client-demo
  • @kintone/rest-api-client
  • @kintone/webpack-plugin-kintone-plugin

Why

Currently, there is no npm script for fixing the lint error for all packages.
Therefore, when a new lint rule is added/modified, and that change affects all packages, we have to access to every package and run the fix lint command.

What

  • Support npm script on the main package.json to fix lint error for all packages, e.g. fix:lint
@hung-cybo hung-cybo added pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: data-loader @kintone/data-loader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-packer @kintone/plugin-packer pkg: plugin-uploader @kintone/plugin-uploader pkg: profile-loader @kintone/profile-loader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin labels Nov 16, 2022
@hung-cybo hung-cybo self-assigned this Dec 12, 2022
@hung-cybo hung-cybo mentioned this issue Dec 12, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hung-cybo hung-cybo

Labels
pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: data-loader @kintone/data-loader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-packer @kintone/plugin-packer pkg: plugin-uploader @kintone/plugin-uploader pkg: profile-loader @kintone/profile-loader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: support npm script to fix lint error for all packages kintone/js-sdk
1 participant
@hung-cybo