Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint to v9 #2690

Closed
wants to merge 12 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 5, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.57.0 -> ^9.3.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "after 9pm,before 9am" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team April 5, 2024 22:01
@renovate renovate bot added the renovate label Apr 5, 2024
@renovate renovate bot requested review from hung-cybo and removed request for a team April 5, 2024 22:01
@github-actions github-actions bot added pkg: dts-gen @kintone/dts-gen pkg: create-plugin @kintone/create-plugin labels Apr 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2690.d1ite8zvzg8c5i.amplifyapp.com

@renovate renovate bot force-pushed the renovate/major-eslint-and-prettier branch 3 times, most recently from 06c59c5 to 556e703 Compare April 12, 2024 16:45
@renovate renovate bot force-pushed the renovate/major-eslint-and-prettier branch 3 times, most recently from 52b344b to 2ca63d8 Compare April 22, 2024 19:36
@renovate renovate bot force-pushed the renovate/major-eslint-and-prettier branch 2 times, most recently from a39a384 to dfdcc0f Compare May 8, 2024 22:57
@renovate renovate bot force-pushed the renovate/major-eslint-and-prettier branch 2 times, most recently from b20bc73 to 580929a Compare May 12, 2024 19:58
@renovate renovate bot force-pushed the renovate/major-eslint-and-prettier branch from 580929a to 6036608 Compare May 17, 2024 23:08
Copy link
Contributor Author

renovate bot commented May 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions github-actions bot added pkg: rest-api-client @kintone/rest-api-client pkg: customize-uploader @kintone/customize-uploader pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-uploader @kintone/plugin-uploader pkg: plugin-packer @kintone/plugin-packer labels Jun 3, 2024
recommendedConfig: js.configs.recommended,
});

module.exports = [
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flat config file format has been the default configuration file format since ESLint v9.0.0
Ref: https://eslint.org/docs/latest/use/configure/migration-guide#start-using-flat-config-files

The previous format, eslintrc, is now deprecated .

eslint.config.js Outdated
...fixupConfigRules(
compat.extends("@cybozu/eslint-config/presets/node-typescript-prettier"),
eslintPluginNode,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using FlatCompat from the @eslint/eslintrc package, you may not be able to access each of the plugins that are referenced inside of an eslintrc-style configuration. In that case, you can use the fixupConfigRules() function to wrap all plugins, as in this example:

// eslint.config.js
import { fixupConfigRules } from "@eslint/compat";
import { FlatCompat } from "@eslint/eslintrc";

const flatCompat = new FlatCompat();

export default [

    ...fixupConfigRules(
        flatCompat.extends("my-config")
    )

    // other config
];

Ref: https://eslint.org/blog/2024/05/eslint-compatibility-utilities/#using-with-flatcompat

const compat = new FlatCompat({
baseDirectory: __dirname,
recommendedConfig: js.configs.recommended,
});
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


module.exports = [
{
files: ["plugin-uploader/**/*.ts"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -48,7 +48,7 @@
"start": "pnpm build --watch",
"build": "pnpm clean && tsc --build --force",
"clean": "rimraf dist",
"lint": "eslint --ext .ts src --max-warnings 0",
"lint": "eslint src --max-warnings 0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following CLI flags are no longer supported with the flat config file format:

--rulesdir
--ext
--resolve-plugins-relative-to

Ref: https://eslint.org/docs/latest/use/configure/migration-guide#cli-flag-changes

@@ -315,7 +313,6 @@ export class RecordClient extends BaseClient {
const { id } = await this.createCursor(params);
try {
let allRecords: T[] = [];
// eslint-disable-next-line no-constant-condition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the recommended config from @eslint/js in a configuration file enables this rule.
Ref: https://eslint.org/docs/latest/rules/no-constant-condition

@tasshi-me tasshi-me closed this Oct 8, 2024
@tasshi-me tasshi-me deleted the renovate/major-eslint-and-prettier branch October 8, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-packer @kintone/plugin-packer pkg: plugin-uploader @kintone/plugin-uploader pkg: rest-api-client @kintone/rest-api-client renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants