Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements addAllRecords. #70

Merged
merged 33 commits into from
Mar 13, 2020
Merged

feat: implements addAllRecords. #70

merged 33 commits into from
Mar 13, 2020

Conversation

shintaroNagata
Copy link
Contributor

@shintaroNagata shintaroNagata commented Feb 28, 2020 •
edited by koba04
Loading

Fixes #102

shintaroNagata and others added 27 commits March 3, 2020 15:09
@shintaroNagata
feat: handle over 2000 records
cd71246
@chick-p
feat: modify response format of addAllRecords
f0b3317
@chick-p
chore: fix typo
531cf42
@zaki-yama
fix: remove unnecessary import
6c678ac
@zaki-yama
feat: define KintoneAllRecordsError
41ad0c1
@koba04
refactor: addAllRecords (#92)
69cf076 
* refactor: modify the implementation of addAllRecords

* refactor: remove unnecessary else
@shintaroNagata
fix: initialize in constructor
aad3240
@koba04
refactor: pass a bulkRequestClient as a parameter of RecordClient's c…
5e6a9d0 
…onstructor
@koba04
refactor: change the record parameter type
016dd2f
@koba04
feat: wip handling an addAllRecords error
2b30c3f
@shintaroNagata
feat: add an errorIndex property in KintoneAllRecordsError
0f1da23
@koba04
refactor: move KintoneAllRecordsError as a seperated file
15ef12f
@koba04
fix: errorParseResult might be 0
5f42327
@b4h0-c4t
refactor: remove magic number.
c4a48b8
@zaki-yama
feat: build KintoneAllRecordsError's message
636bf4d
@koba04
fix: assign this.errorIndex
d994cfd
@koba04
test: add a test for errorIndex property on KintoneAllRecordsError
4383b4c
@zaki-yama
fix: avoid implicit any
469c631
@zaki-yama
test: add a test for processedRecordsResult, unprocessedRecords, and …
74a0ea5 
…error on KintoneAllRecordsError
@zaki-yama
test: add a test for message on KintoneAllRecordsError
3690f41
@zaki-yama
test: add tests for success in addAllRecords
478b2ce
@koba04
test: add tests for addAllRecords to handle errors
de09a13
@koba04
refactor: create convertResponse function
ab6029c
@koba04
refactor: rename a function in a test
48fef52
@koba04
chore: decrease the record count for addAllRecords in scripts/
9cfdf32
@koba04
docs: write a draft documentation for addAllRecords
972831a
@koba04
docs: add a link to addAllRecords in addRecords
2486063
@zaki-yama zaki-yama marked this pull request as ready for review March 13, 2020 07:04
@zaki-yama zaki-yama merged commit 6c7006b into master Mar 13, 2020
@zaki-yama zaki-yama deleted the add-all-records branch March 13, 2020 07:26
koba04 pushed a commit that referenced this pull request Mar 18, 2020
@renovate @koba04
chore(deps): update dependency tslint to ^5.12.0 (#70)
bc85a1a
koba04 pushed a commit that referenced this pull request Mar 27, 2020
@renovate @koba04
chore(deps): update dependency tslint to ^5.12.0 (#70)
6f67154
shisama pushed a commit that referenced this pull request Jun 2, 2020
@renovate @shisama
chore(deps): lock file maintenance (#70)
87cf940
koba04 added a commit that referenced this pull request Jul 22, 2020
@koba04
feat(cli): add --watch option to create a plugin zip automatically (#70)
b7488b3
koba04 added a commit that referenced this pull request Sep 8, 2020
@koba04
feat: add error messages for login and admin privilege (#70)
d0dd268
koba04 pushed a commit that referenced this pull request Sep 18, 2020
@shohei-ihaya @koba04
fix: Use option 'params' instead of 'data' at axios request (#70)
dcc73ec 
* Use option 'params' instead of 'data' at axios request

* Fix test
@tasshi-me tasshi-me added the pkg: rest-api-client @kintone/rest-api-client label Mar 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: addAllRecords
6 participants
@shintaroNagata @zaki-yama @tasshi-me @chick-p @koba04 @b4h0-c4t