Remove reader.py:read_file_contents - unused

[kinverarity1]

I think as part of #327 I was probably meant to remove the function reader.py:read_file_contents. All tests pass without this function, however coverage is not 100% so I want to be sure before removing the code.

@dcslagel you have probably looked more closely over the related changes than I did; does this seem right to you?

[dcslagel]

@kinverarity1, I have a caution about removing read_file_contents() too quickly also.

I did the following searches that show Lasio is no-longer calling read_file_contents.

$ cd lasio
$ grep -rl read_file_contents *
docs/source/lasio.rst
htmlcov/lasio_las_py.html
htmlcov/lasio_debug-reader_py.html
htmlcov/lasio_reader_py.html
lasio/reader.py

$ grep  read_file_contents lasio/reader.py
def read_file_contents(

However, In scanning the removing read_file_contents() code, there are some interesting details we should check whether if they are relevant and if so, exist in the new code.

Could this pull-request be kept around for a while to give us time to read through the code through read through?

Thanks,
DC

[kinverarity1]

Yep no hurry 👍

[dcslagel]

@kinverarity1, I reviewed reader:read_file_contents() and compared with the current code. It is okay to proceed with removing reader:read_file_contents().

Findings:

• Re-add try-except check around call to reader.read_data_section_iterative() #401 suggests re-adding a try clause wasn't in the new code but looks like it is still relevant.

[kinverarity1]

Thanks @dcslagel