Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add try-except check around call to reader.read_data_section_iterative() #401

Merged

Conversation

dcslagel
Copy link
Collaborator

@dcslagel dcslagel commented Sep 15, 2020

Description:

This pull-request is a finding from reviewing read_file_contents() for removal. It adds back a try check around reader.read_data_section_iterative(). This try also re-enables Cntrl-C via raising a KeyboardInterrupt exception.
For reference, the original commits were: 2d9e43c and e960998.

I think we still want this code, but not 100% sure. :-)

Test Results

The test results with or without this change are the same. There isn't test coverage for it at this time.

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py             13      2    85%
lasio/convert_version.py      20     20     0%
lasio/defaults.py             11      0   100%
lasio/examples.py             42     10    76%
lasio/excel.py                88     34    61%
lasio/exceptions.py            6      0   100%
lasio/las.py                 389     59    85%
lasio/las_items.py           190     31    84%
lasio/las_version.py          50     10    80%
lasio/reader.py              457     84    82%
lasio/writer.py              168      9    95%
----------------------------------------------
TOTAL                       1434    259    82%

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC

This change adds back a `try` around the read_data_section_iterative()
function. This was removed during the original rearrange_reader effort.
For reference, the original commits were: 2d9e43c and e960998.
@dcslagel
Copy link
Collaborator Author

@kinverarity1,

Just checking on this pull-request. I think it is ready to merge, but let me know if it needs changes or is rejected.

Thanks,
DC

@kinverarity1
Copy link
Owner

Thank you @dcslagel

@kinverarity1 kinverarity1 merged commit 9feac1b into kinverarity1:master Jan 19, 2021
@dcslagel dcslagel deleted the re-add-try-around-read-data branch February 20, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants