Re-add try-except check around call to reader.read_data_section_iterative() #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull-request is a finding from reviewing read_file_contents() for removal. It adds back a
try
check around reader.read_data_section_iterative(). This try also re-enables Cntrl-C via raising aKeyboardInterrupt exception
.For reference, the original commits were: 2d9e43c and e960998.
I think we still want this code, but not 100% sure. :-)
Test Results
The test results with or without this change are the same. There isn't test coverage for it at this time.
Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.
Thank you,
DC