Add test for timestring with colon in ~Well section #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit add a test case for issue #419 "Colons in date formats for STRT/STOP confuse parser"
The test case is
tests/test_read_header_line.py::test_time_str_and_colon_in_desc_2Test Notes:
This test case passes with Python 3.9.1 with Lasio 0.28.
It properly parses the time string to the value field:
{'name': 'STRT', 'unit': 'DateTime', 'value': '2012-09-16T07:44:12-05:00', 'descr': 'START DEPTH'}Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.
Thank you,
DC