Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Rename Packet to Equinix Metal in existing Documentation. #1537

Merged
merged 7 commits into from Aug 4, 2021

Conversation

ipochi
Copy link
Member

@ipochi ipochi commented Jul 22, 2021

This PR replaces the name Packet with Equinix Metal in all the existing documentation resources under docs/

Fixes: #1060

This PR only takes care of renaming on the documentation side, more work and careful thought process would be required in migrating from Packet terraform provider to Equinix Metal terraform provider, such that there is little or no effect on existing clusters during upgrade.

More specifically, this migration guide will need to be followed
https://registry.terraform.io/providers/equinix/metal/latest/docs/guides/migration_guide_packet

This commit introduces renaming "Packet" to "Equinix Metal" in all files
under `docs/concepts`.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files
under `docs/troubleshooting`.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files
under `docs/configuration-reference`.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files
under `docs/quickstarts`.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files
under `docs/how-to-guides`.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi requested review from surajssd and invidian July 22, 2021 16:23
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have some concerns about documentation talking about EM and code saying Packet all over the place. This is confusing for end user. I'd expect code changes to fall into the same release as this PR, so transition period is only "internally".

Also, this does not solve #1060, only partially addresses it.

Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. But same concern as @invidian. I think we can create a different issue than #1060. for addressing changes on terraform level.

@ipochi ipochi merged commit 09579eb into master Aug 4, 2021
@ipochi ipochi deleted the imran/rename-packet-to-equinix-metal branch August 4, 2021 14:57
@rata
Copy link
Member

rata commented Aug 4, 2021

@invidian @knrt10 I disagree, IMHO this address the issue taking into account the comment that we added during the sprint planning: #1060 (comment)

@ipochi
Copy link
Member Author

ipochi commented Aug 4, 2021

@invidian @rata @knrt10

The user facing documentation is whats visible to the end user more so that any other piece of code/config.

I understand your concern however, making it part of the single PR would have meant a possible delay of getting the user documentation changes merged, which was top priority anyway.

Hence I closed the original issue #1060 , created another issue #1546 that tracks the code and config related changes from Packet to Equinix Metal.

#1545 tries to address #1546

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all Packet references to Equinix Metal
4 participants