Code and config change: Packet to equinixmetal #1545

ipochi · 2021-08-03T13:10:51Z

This PR builds on top of #1537 by adding code and configuration changes to migrate from Packet to Equinix Metal.

Addresses: #1546

The following changes will take affect after this PR is merged.

Terraform provider packethost/packet is replaced with equinix/metal.
Cluster configuration for Equinix Metal is changed from cluster "packet" {} to cluster "equinixmetal" {}

Migration steps:

Backup existing clusters state file

cd assets/terraform/
terraform state pull > terraform.tfstate.backup

Uninstall packet-ccm helm release

helm uninstall packet-ccm --namespace kube-system

Replace the packethost/packet Terraform provider with equinix/metal:

terraform state replace-provider packethost/packet equinix/metal

Replace all references of packet_ to metal_ in the terraform state file.

 sed -i 's/packet_/metal_/g' terraform.tfstate

Change the module name module.packet to module.equinixmetal in the terraform state file

sed -i 's/module.packet/module.equinixmetal/g' terraform.tfstate

Edit the cluster module in cluster configuration file(lokocfg) from packet to equinixmetal, example:

cluster "equinixmetal" {}

Upgrade
Note: Do not forget the --skip-pre-update-health-check flag

    lokoctl cluster apply --skip-components --skip-pre-update-health-check

Terraform plan should reflect the following changes: Lokomotive control plane and components update, removal of packet-ccm , update of the lokoctl-version and the addition of cloud-provider-equinix-metal.

Upgrade Lokomotive cluster to the latest release by proceeding with the cluster apply in step 5 with yes

Update MetalLB:

lokoctl component apply metallb

invidian · 2021-08-03T19:39:51Z

sed -i 's/packet_/metal_/g' terraform.tfstate

I'd rather use terraform state mv. Why sed?

invidian

I'm not sure if it make sense to break down the renaming into this many commits. Even though it would be a single, large changeset, it would be more atomic to do those changes in single commit, especially that we also mix some link fixing as part of this PR.

I also think some mentions of Packet are still not renamed, as git grep -i packet gives plenty of legitimate results, like:

.golangci.yml:    - packet
.golangci.yml:    - packet_fluo
...
assets/charts/control-plane/packet-ccm/Chart.yaml:name: packet-ccm
...
docs/configuration-reference/components/cluster-autoscaler.md:  provider = "packet"
...
scripts/find-updates.sh:get_latest_release packethost/terraform-provider-packet
...
test/calico/metadata_access_test.go:    case testutil.PlatformPacket, testutil.PlatformPacketARM:
...

I'm fine if some of those should be considered out of scope for this PR, but still it would be nice to remain as consistent as possible.

Perhaps this one requires a migration or a feature request to Flatcar?

assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/cl/controller.yaml.tmpl:        ExecStart=/bin/sh -c 'echo "ETCD_LISTEN_CLIENT_URLS=https://$COREOS_PACKET_IPV4_PRIVATE_0:2379" > /etc/kubernetes/etcd.config && echo "ETCD_LISTEN_PEER_URLS=https://$COREOS_PACKET_IPV4_PRIVATE_0:2380" >> /etc/kubernetes/etcd.config && echo "ETCD_LISTEN_METRICS_URLS=http://$COREOS_PACKET_IPV4_PRIVATE_0:2381" >> /etc/kubernetes/etcd.config'

But overall looks good. Nice work @ipochi, a lot of effort into making this finally happen!

docs/concepts/dns.md

docs/configuration-reference/components/cluster-autoscaler.md

pkg/platform/equinixmetal/equinixmetal.go

Makefile

ipochi · 2021-08-04T05:30:29Z

sed -i 's/packet_/metal_/g' terraform.tfstate

I'd rather use terraform state mv. Why sed?

Migration Guide used sed so thats what I went with.

invidian · 2021-08-04T08:11:12Z

Migration Guide used sed so thats what I went with.

Hmm, can we at least try to see if terraform state mv works?

ipochi · 2021-08-06T08:31:18Z

@invidian
Regarding the so many commits. It was getting harder to track and also would be harder to review.

I've tried to make sure that after every commit I run lokoctl apply on an existing cluster(before the name change) so that there are no plan changes.

Making it a single large commit would be a lot to deal with review and maintain sanity.

However what we can do is that we can review as multiple commits and then when I get LGTM I can squash all commits into one.

ipochi · 2021-08-06T14:33:22Z

@invidian
addressed some feedback, migrated from packet-ccm to cloud-provider-equinix-metal.

invidian

LGTM, but there is still some code referencing Packet from what I see. Is it going to be addressed in the following PR?

ipochi · 2021-08-12T10:38:30Z

Regarding the usage of terraform mv instead of sed

I couldn't get it to work for all the resources, example:

terraform state mv module.worker-small.data.metal_project.project module.worker-small.data.packet_project.project

Error: Invalid state move request

Cannot move module.worker-small.data.metal_project.project to
module.worker-small.data.packet_project.project: resource types don't match.

This makes use use sed for only the above data resource. Instead I'd propose using sed for all the steps as is the case with the migration guide.

For cluster-autoscaler

Upstream repo does not have any changes w.r.t renaming from Packet -> Equinix Metal.
Upstream autoscaler helm chart expects cloudProvider: packet

We have an optional Provider field in component config which we set it to packet and a packet config block.
If we change the user facing variables from packet to equinixmetal , internally we have to do some mapping in either go code or in helm templates along the lines of:

if cloudProvider is equinixmetal, then set `--cloudProvider= packet`

which by the looks of it is hacky and ugly.

I am of the opinion that we should leave the cluster-autoscaler as is. Instead focus on updating to the latest helm chart. The latest release has a commit that fixes some API errors (no sure if it fixes everything) but it would be good to get the latest chart.

Your opinions: @invidian @iaguis ?

iaguis · 2021-08-12T13:55:15Z

If we need to use sed for one of them I agree using it for all of them makes sense.
I agree we shouldn't make the changes upstream just now. Let's leave it as Packet.

invidian · 2021-08-18T14:30:50Z

Sounds good to me as well. Thanks for investigating @ipochi 👍

invidian · 2021-08-18T14:39:28Z

I still see a lot of references to Packet, which can definitely be changed to Equnix Metal:

$ git grep -i packet | grep -v cluster-autoscaler | grep -v vendor | grep -v formerly | grep -v packethost | grep -v packet.ipxe | grep -v PACKET_AUTH | grep -v prometheus-operator | grep -v calico | grep -v terraform-provider-packet | grep -v scripts/update | grep -v CHANGELOG.md | grep -v COREOS_PACKET | grep -i packet
README.md:* [Packet quickstart](https://kinvolk.io/docs/lokomotive/latest/quickstarts/packet)
README.md:* [Kubernetes storage with Rook Ceph on Packet cloud](https://kinvolk.io/docs/lokomotive/latest/how-to-guides/rook-ceph-storage)
README.md:* [Setting up an HTTP ingress controller on Lokomotive with MetalLB and Contour on Packet](https://kinvolk.io/docs/lokomotive/latest/how-to-guides/ingress-with-contour-metallb)
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/bootkube.tf:  # Select private Packet NIC by using the can-reach Calico autodetection option with the first
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/bootkube.tf:  # Block access to Packet metadata service.
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/bootkube.tf:  # https://www.packet.com/developers/docs/servers/key-features/metadata/
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/bootkube.tf:  # metadata.packet.net should always resolve to 192.80.8.124.
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/cl/controller.yaml.tmpl:          # Use 10.0.0.0/8 as this is Packet private network CIDR.
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/controllers.tf:      // With newer Packet provider, changing userdata causes re-creation of the device,
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/controllers.tf:    flatcar_linux_oem    = "packet"
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/controllers.tf:  platform = "packet"
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/workers/cl/worker.yaml.tmpl:          # Use 10.0.0.0/8 as this is Packet private network CIDR.
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/workers/workers.tf:      // With newer Packet provider, changing userdata causes re-creation of the device,
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/workers/workers.tf:    flatcar_linux_oem    = "packet"
...

ipochi · 2021-08-23T14:28:09Z

@invidian

assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/controllers.tf:    flatcar_linux_oem    = "packet"
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/controllers.tf:  platform = "packet"
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/workers/workers.tf:    flatcar_linux_oem    = "packet"
assets/terraform-modules/equinixmetal/flatcar-linux/kubernetes/workers/workers.tf:  platform = "packet"
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_ENV: ${PACKET_ENV:-testing}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_VERSION: ${PACKET_VERSION:-ignored}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      API_AUTH_TOKEN: ${PACKET_API_AUTH_TOKEN:-ignored}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      API_CONSUMER_TOKEN: ${PACKET_CONSUMER_TOKEN:-ignored}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_ENV: ${PACKET_ENV:-testing}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_VERSION: ${PACKET_VERSION:-ignored}
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_ENV: testing
assets/terraform-modules/tinkerbell-sandbox/assets/deploy/docker-compose.yml:      PACKET_VERSION: ${PACKET_VERSION:-ignored}
assets/terraform-modules/tinkerbell-sandbox/assets/setup.sh:			| .hosts += [ $ip, "tinkerbell.\($facility).packet.net" ]
ci/packet/packet-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet/packet-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:  packet {
ci/packet/packet-cluster.lokocfg.envsubst:    project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:    facility   = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/scripts/deploy-cluster.sh:packet|packet_fluo)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:packet_arm)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:cat "$platform-cluster.lokocfg.envsubst" | envsubst '$AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY $PUB_KEY $CLUSTER_ID $AWS_DEFAULT_REGION $AWS_DNS_ZONE $AWS_DNS_ZONE_ID $PACKET_PROJECT_ID $EMAIL $GITHUB_CLIENT_ID $GITHUB_CLIENT_SECRET $DEX_STATIC_CLIENT_CLUSTERAUTH_ID $DEX_STATIC_CLIENT_CLUSTERAUTH_SECRET $GANGWAY_REDIRECT_URL $GANGWAY_SESSION_KEY $DEX_INGRESS_HOST $GANGWAY_INGRESS_HOST $ISSUER_HOST $REDIRECT_URI $API_SERVER_URL $AUTHORIZE_URL $TOKEN_URL $PACKET_LOCATION $ARM_SUBSCRIPTION_ID $ARM_TENANT_ID $ARM_CLIENT_ID $ARM_CLIENT_SECRET' >"$platform-cluster.lokocfg"
ci/scripts/deploy-cluster.sh:  if [ "$platform" == "packet" ] || [ "$platform" == "packet_fluo" ]; then
test/platform/equinixmetal/equinixmetal_test.go:		t.Fatalf("Creating Packet API client: %v", err)
test/platform/equinixmetal/equinixmetal_test.go:	projectID := os.Getenv("PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:		t.Fatalf("Packet project ID can't be empty. Is %q environment variable set?", "PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:		t.Fatalf("No Packet device found with hostname %q", hostname)

The following things show packet, some of them are related to cluster autoscaler.

Not sure if any of them needs to change or the potential impact of breakage in CI.

invidian · 2021-08-23T14:35:28Z

@ipochi I think the following can still be changed, though they require changes to CI configuration as well. I think all can be rolled out gracefully though.

ci/packet/packet-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet/packet-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:  packet {
ci/packet/packet-cluster.lokocfg.envsubst:    project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:    facility   = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/scripts/deploy-cluster.sh:packet|packet_fluo)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:packet_arm)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:cat "$platform-cluster.lokocfg.envsubst" | envsubst '$AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY $PUB_KEY $CLUSTER_ID $AWS_DEFAULT_REGION $AWS_DNS_ZONE $AWS_DNS_ZONE_ID $PACKET_PROJECT_ID $EMAIL $GITHUB_CLIENT_ID $GITHUB_CLIENT_SECRET $DEX_STATIC_CLIENT_CLUSTERAUTH_ID $DEX_STATIC_CLIENT_CLUSTERAUTH_SECRET $GANGWAY_REDIRECT_URL $GANGWAY_SESSION_KEY $DEX_INGRESS_HOST $GANGWAY_INGRESS_HOST $ISSUER_HOST $REDIRECT_URI $API_SERVER_URL $AUTHORIZE_URL $TOKEN_URL $PACKET_LOCATION $ARM_SUBSCRIPTION_ID $ARM_TENANT_ID $ARM_CLIENT_ID $ARM_CLIENT_SECRET' >"$platform-cluster.lokocfg"
ci/scripts/deploy-cluster.sh:  if [ "$platform" == "packet" ] || [ "$platform" == "packet_fluo" ]; then
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("Creating Packet API client: %v", err)
test/platform/equinixmetal/equinixmetal_test.go:        projectID := os.Getenv("PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("Packet project ID can't be empty. Is %q environment variable set?", "PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("No Packet device found with hostname %q", hostname)

ipochi · 2021-08-23T14:43:17Z

@ipochi I think the following can still be changed, though they require changes to CI configuration as well. I think all can be rolled out gracefully though.

ci/packet/packet-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet/packet-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:  packet {
ci/packet/packet-cluster.lokocfg.envsubst:    project_id = "$PACKET_PROJECT_ID"
ci/packet/packet-cluster.lokocfg.envsubst:    facility   = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_arm/packet_arm-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  facility = "$PACKET_LOCATION"
ci/packet_fluo/packet_fluo-cluster.lokocfg.envsubst:  project_id = "$PACKET_PROJECT_ID"
ci/scripts/deploy-cluster.sh:packet|packet_fluo)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:packet_arm)
ci/scripts/deploy-cluster.sh:    export PACKET_LOCATION=${AVAIL_LOCATIONS_ARRAY[$RANDOM % ${#AVAIL_LOCATIONS_ARRAY[@]}]}
ci/scripts/deploy-cluster.sh:cat "$platform-cluster.lokocfg.envsubst" | envsubst '$AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY $PUB_KEY $CLUSTER_ID $AWS_DEFAULT_REGION $AWS_DNS_ZONE $AWS_DNS_ZONE_ID $PACKET_PROJECT_ID $EMAIL $GITHUB_CLIENT_ID $GITHUB_CLIENT_SECRET $DEX_STATIC_CLIENT_CLUSTERAUTH_ID $DEX_STATIC_CLIENT_CLUSTERAUTH_SECRET $GANGWAY_REDIRECT_URL $GANGWAY_SESSION_KEY $DEX_INGRESS_HOST $GANGWAY_INGRESS_HOST $ISSUER_HOST $REDIRECT_URI $API_SERVER_URL $AUTHORIZE_URL $TOKEN_URL $PACKET_LOCATION $ARM_SUBSCRIPTION_ID $ARM_TENANT_ID $ARM_CLIENT_ID $ARM_CLIENT_SECRET' >"$platform-cluster.lokocfg"
ci/scripts/deploy-cluster.sh:  if [ "$platform" == "packet" ] || [ "$platform" == "packet_fluo" ]; then
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("Creating Packet API client: %v", err)
test/platform/equinixmetal/equinixmetal_test.go:        projectID := os.Getenv("PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("Packet project ID can't be empty. Is %q environment variable set?", "PACKET_PROJECT_ID")
test/platform/equinixmetal/equinixmetal_test.go:                t.Fatalf("No Packet device found with hostname %q", hostname)

These would require changes in the ci repo as well right ?

invidian · 2021-08-23T14:58:26Z

Yes, but I'm fine with doing this changes in the lockstep. Adding support for new names here, then changing CI, then removing the support from here.

ipochi · 2021-08-24T09:29:01Z

Yes, but I'm fine with doing this changes in the lockstep. Adding support for new names here, then changing CI, then removing the support from here.

Updated all the necessary references, please review.
Corresponding CI PR is at kinvolk/lokomotive-ci/pull/196

ipochi · 2021-09-03T08:11:06Z

Finally I have the CI green for Packet in a separate pipeline.

https://yard.lokomotive-k8s.net/teams/main/pipelines/packet-to-em-test/jobs/test-lokomotive-equinixmetal-deployment/builds/2

The issue was related to CCM on two folds.

Newer CCM provides multiple peers support via comma separated values in the same annotation. However MetalLB fails to consume this information and fails. Thereby BGP session is never established and hence the Prometheus component metrics test metallb_bgp_session_up fails.

This patch fixes the issue: kinvolk/metallb@86016b7

It is a workaround and ideally the fix should be in CCM.

Issue: kubernetes-sigs/cloud-provider-equinix-metal#199

For Lokomotive in Equinix Metal , we don't want the CCM to interfere in loadbalancing but only care about BGP. The setting for that is loadbalancer: empty://. However despite setting the required setting, Node and Service reconcilers are started.

More details on the issue: kubernetes-sigs/cloud-provider-equinix-metal#200

PR: kubernetes-sigs/cloud-provider-equinix-metal#201

/cc @iaguis @invidian @surajssd

ipochi · 2021-09-07T12:28:46Z

@invidian @iaguis @surajssd

CI is Green for Equinix Metal and Equinix Metal ARM in separate pipelines

https://yard.lokomotive-k8s.net/teams/main/pipelines/packet-to-em-test/jobs/test-lokomotive-equinixmetal-deployment/builds/2

https://yard.lokomotive-k8s.net/teams/main/pipelines/packet-to-em-test-arm/jobs/test-lokomotive-equinixmetal-deployment/builds/2

Once this is merged and its corresponding CI PR https://github.com/kinvolk/lokomotive-ci/pull/196 , we would need to pause the pipelines, rename them and unpause them.

invidian · 2021-09-07T13:09:25Z

CI is Green for Equinix Metal and Equinix Metal ARM in separate pipelines

Why can't we make it pass on existing pipelines?

ipochi · 2021-09-07T13:12:57Z

CI is Green for Equinix Metal and Equinix Metal ARM in separate pipelines

Why can't we make it pass on existing pipelines?

Need to merge https://github.com/kinvolk/lokomotive-ci/pull/196 first, then unpause and rename and updates pipelines.
Then we can pass on existing pipelines.

invidian · 2021-09-07T13:14:46Z

Need to merge kinvolk/lokomotive-ci#196 first, then unpause and rename and updates pipelines.
Then we can pass on existing pipelines

This won't be existing pipelines anymore.

iaguis · 2021-09-07T14:17:32Z

Let's just merge this and switch the CIs later if that's easier. It's not that big of a deal if we're not in a perfect CI state all the time.

invidian

LGTM

ipochi · 2021-09-08T13:08:51Z

@surajssd @invidian
Squashed commits and rebased.

Please review again.

.golangci.yml

invidian

If CI is passing somewhere and Ingress remains working, LGTM 👍

This commit migrates terraform related resources from Packet to Equinix Metal. It does so by: - replacing the Terraform provider `packethost/packet` with `equinix/metal`. - replacing the prefix `packet_` in `assets/terraform/packet/*` *.tf files with the prefix `metal_`. - Updates the module name from `module.packet` to `module.equinixmetal`, renames the directory `assets/terraform-modules/packet` to `assets/terraform-modules/equinixmetal` - change description in Terraform variables to Equinix Metal - rename code references from Packet to EquinixMetal - test: rename file and dir to equinixmetal - build tags: rename from packet to equinixmetal - docs: update packet to equinixmetal in configuration - ci: change packet to equinixmetal in cluster config - scripts: replace Packet with Equinix Metal - test: Rename PlatformPacket to PlatformEquinixMetal - update env vars referencing Packet to EM - ci: packet to equinixmetal Signed-off-by: Imran Pochi <imran@kinvolk.io>

This commit removes the Packet Cloud Controller Manager a.k.a packet-ccm as part of the migration to Equinix Metal. In its place, `cloud-provider-equinix-metal` is installed. For new Lokomotive clusters there won't be any difference because well the are fresh clusters. However, for existing clusters, users would need to uninstall the `packet-ccm` helm release and then proceed with cluster upgrade using `lokoctl cluster apply ...`. Note: During upgrade the user must pass the flag `--skip-pre-update-health-check`. Execution steps for existing clusters: 1. Uninstall `packet-ccm` helm release ``` helm uninstall packet-ccm --namespace kube-system ``` 2. Upgrade Lokomotive cluster to the latest release Note: Do not forget the `--skip-pre-update-health-check` flag ``` lokoctl cluster apply --skip-components --skip-pre-update-health-check ``` Signed-off-by: Imran Pochi <imran@kinvolk.io>

This image includes the PR: kubernetes-sigs/cloud-provider-equinix-metal#201 Signed-off-by: Imran Pochi <imran@kinvolk.io>

This commit removes the labels passed to the MetalLB ConfigMap, from nowonwards we only pass annotations. Also removes the custom values such as `metallb.lokomotive.io/<string>` for my-asn, peer-address, peer-asn and source-address. Since the move from Packet CCM to Cloud Provider Equinix Metal, we have removed such custom annotation values from CCM and hence, these values are removed from MetalLB as well. Also updated the MetalLB image to include a fix for supporting multiple peers. This image is based on top of peer autodiscovery support (metallb/metallb#593) and additionally contains the below commit on top. kinvolk/metallb@86016b7 Signed-off-by: Imran Pochi <imran@kinvolk.io>

ipochi requested review from iaguis, surajssd and invidian August 3, 2021 13:10

ipochi force-pushed the imran/packet-to-equinixmetal branch from 478161a to b89c4d9 Compare August 3, 2021 13:25

invidian reviewed Aug 3, 2021

View reviewed changes

docs/concepts/dns.md Outdated Show resolved Hide resolved

docs/configuration-reference/components/cluster-autoscaler.md Outdated Show resolved Hide resolved

pkg/platform/equinixmetal/equinixmetal.go Outdated Show resolved Hide resolved

Makefile Show resolved Hide resolved

This was referenced Aug 4, 2021

Rename all Packet references to Equinix Metal #1060

Closed

Rename Packet to Equinix Metal in existing Documentation. #1537

Merged

ipochi force-pushed the imran/packet-to-equinixmetal branch from b89c4d9 to 69eceee Compare August 6, 2021 14:33

invidian previously approved these changes Aug 10, 2021

View reviewed changes

ipochi dismissed invidian’s stale review via ebe6944 August 17, 2021 06:15

ipochi force-pushed the imran/packet-to-equinixmetal branch from 69eceee to ebe6944 Compare August 17, 2021 06:15

invidian mentioned this pull request Aug 18, 2021

[RFE] Rename flatcar_production_packet.ipxe to flatcar_production_equinix_metal.ipxe flatcar/Flatcar#483

Open

ipochi force-pushed the imran/packet-to-equinixmetal branch 3 times, most recently from 1838203 to 7ebaed2 Compare August 23, 2021 11:13

ipochi force-pushed the imran/packet-to-equinixmetal branch from 7ebaed2 to 7e50b66 Compare August 23, 2021 14:28

ipochi force-pushed the imran/packet-to-equinixmetal branch from bd44933 to cf58666 Compare September 6, 2021 07:37

ipochi force-pushed the imran/packet-to-equinixmetal branch 2 times, most recently from 56cd24a to e4a12d3 Compare September 7, 2021 12:45

invidian previously approved these changes Sep 7, 2021

View reviewed changes

ipochi dismissed invidian’s stale review via 9314031 September 8, 2021 13:03

ipochi force-pushed the imran/packet-to-equinixmetal branch from e4a12d3 to 9314031 Compare September 8, 2021 13:03

surajssd reviewed Sep 8, 2021

View reviewed changes

.golangci.yml Show resolved Hide resolved

invidian previously approved these changes Sep 8, 2021

View reviewed changes

ipochi dismissed invidian’s stale review via 9736966 September 8, 2021 13:54

ipochi force-pushed the imran/packet-to-equinixmetal branch from 9314031 to 9736966 Compare September 8, 2021 13:54

ipochi added 3 commits September 8, 2021 19:24

control-plane: use custom cloud-provider-equinix-metal image

2dee6ec

This image includes the PR: kubernetes-sigs/cloud-provider-equinix-metal#201 Signed-off-by: Imran Pochi <imran@kinvolk.io>

invidian previously approved these changes Sep 8, 2021

View reviewed changes

surajssd previously approved these changes Sep 8, 2021

View reviewed changes

ipochi dismissed stale reviews from surajssd and invidian via 1136eb2 September 8, 2021 16:14

ipochi force-pushed the imran/packet-to-equinixmetal branch from 9736966 to 1136eb2 Compare September 8, 2021 16:14

invidian approved these changes Sep 8, 2021

View reviewed changes

surajssd approved these changes Sep 9, 2021

View reviewed changes

ipochi merged commit bb28af1 into master Sep 9, 2021

ipochi deleted the imran/packet-to-equinixmetal branch September 9, 2021 05:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code and config change: Packet to equinixmetal #1545

Code and config change: Packet to equinixmetal #1545

ipochi commented Aug 3, 2021 •

edited

invidian commented Aug 3, 2021

invidian left a comment

ipochi commented Aug 4, 2021

invidian commented Aug 4, 2021

ipochi commented Aug 6, 2021 •

edited

ipochi commented Aug 6, 2021

invidian left a comment

ipochi commented Aug 12, 2021

iaguis commented Aug 12, 2021

invidian commented Aug 18, 2021

invidian commented Aug 18, 2021

ipochi commented Aug 23, 2021

invidian commented Aug 23, 2021

ipochi commented Aug 23, 2021 •

edited

invidian commented Aug 23, 2021

ipochi commented Aug 24, 2021

ipochi commented Sep 3, 2021 •

edited

ipochi commented Sep 7, 2021

invidian commented Sep 7, 2021

ipochi commented Sep 7, 2021 •

edited

invidian commented Sep 7, 2021

iaguis commented Sep 7, 2021 •

edited

invidian left a comment

ipochi commented Sep 8, 2021

invidian left a comment

Code and config change: Packet to equinixmetal #1545

Code and config change: Packet to equinixmetal #1545

Conversation

ipochi commented Aug 3, 2021 • edited

invidian commented Aug 3, 2021

invidian left a comment

Choose a reason for hiding this comment

ipochi commented Aug 4, 2021

invidian commented Aug 4, 2021

ipochi commented Aug 6, 2021 • edited

ipochi commented Aug 6, 2021

invidian left a comment

Choose a reason for hiding this comment

ipochi commented Aug 12, 2021

iaguis commented Aug 12, 2021

invidian commented Aug 18, 2021

invidian commented Aug 18, 2021

ipochi commented Aug 23, 2021

invidian commented Aug 23, 2021

ipochi commented Aug 23, 2021 • edited

invidian commented Aug 23, 2021

ipochi commented Aug 24, 2021

ipochi commented Sep 3, 2021 • edited

ipochi commented Sep 7, 2021

invidian commented Sep 7, 2021

ipochi commented Sep 7, 2021 • edited

invidian commented Sep 7, 2021

iaguis commented Sep 7, 2021 • edited

invidian left a comment

Choose a reason for hiding this comment

ipochi commented Sep 8, 2021

invidian left a comment

Choose a reason for hiding this comment

ipochi commented Aug 3, 2021 •

edited

ipochi commented Aug 6, 2021 •

edited

ipochi commented Aug 23, 2021 •

edited

ipochi commented Sep 3, 2021 •

edited

ipochi commented Sep 7, 2021 •

edited

iaguis commented Sep 7, 2021 •

edited