Skip to content

Commit

Permalink
[PA-RISC] Fix must_check warnings in drivers.c
Browse files Browse the repository at this point in the history
Panic if we can't register the parisc bus or the root parisc device.
There's no way we can boot without them, so let the user know ASAP.

If we can't register a parisc device, handle the failure gracefully.

Signed-off-by: Matthew Wilcox <willy@parisc-linux.org>
  • Loading branch information
Matthew Wilcox authored and Matthew Wilcox committed Oct 5, 2006
1 parent f64ef29 commit 1070c96
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions arch/parisc/kernel/drivers.c
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,10 @@ struct parisc_device * create_tree_node(char id, struct device *parent)
/* make the generic dma mask a pointer to the parisc one */
dev->dev.dma_mask = &dev->dma_mask;
dev->dev.coherent_dma_mask = dev->dma_mask;
device_register(&dev->dev);
if (!device_register(&dev->dev)) {
kfree(dev);
return NULL;
}

return dev;
}
Expand Down Expand Up @@ -850,8 +853,10 @@ static void print_parisc_device(struct parisc_device *dev)
*/
void init_parisc_bus(void)
{
bus_register(&parisc_bus_type);
device_register(&root);
if (!bus_register(&parisc_bus_type))
panic("Could not register PA-RISC bus type\n");
if (!device_register(&root))
panic("Could not register PA-RISC root device\n");
get_device(&root);
}

Expand Down

0 comments on commit 1070c96

Please sign in to comment.