Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relations from DTOs #16

Closed
DannySS123 opened this issue May 27, 2024 · 0 comments · Fixed by #24
Closed

Remove relations from DTOs #16

DannySS123 opened this issue May 27, 2024 · 0 comments · Fixed by #24
Assignees
Labels
backend bug Something isn't working good first issue Good for newcomers

Comments

@DannySS123
Copy link

DannySS123 commented May 27, 2024

The relations are defined in the prisma.schema file, so we don't usually need them in the DTOs.
If there was an endpoint, that would return more things, for that we could create a DTO containing other fields as well.
But for now, let's just remove all fields from the DTOs (every entity.ts) that represent relations. (Like: ownedEvents: Event[] in the User DTO)

@DannySS123 DannySS123 added bug Something isn't working good first issue Good for newcomers labels May 27, 2024
@martonbakk martonbakk self-assigned this May 28, 2024
@DannySS123 DannySS123 mentioned this issue May 29, 2024
@SzBeni2003 SzBeni2003 linked a pull request Jul 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants