Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Migrate to Ionic standalone components #3342

Closed
1 of 11 tasks
RasmusKjeldgaard opened this issue Jan 18, 2024 · 0 comments · Fixed by #3349
Closed
1 of 11 tasks

[Enhancement] Migrate to Ionic standalone components #3342

RasmusKjeldgaard opened this issue Jan 18, 2024 · 0 comments · Fixed by #3349
Assignees
Labels
enhancement New feature or request

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the enhancement

Angular 17 ships with a new build system based on ESM, esbuild and vite, and this is the default system used for new applications.

To allow consumers to benefit from this, we need to migrate to Ionics standalone components as detailed here:
https://ionicframework.com/docs/angular/build-options#overview


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jan 18, 2024
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jan 23, 2024
@RasmusKjeldgaard RasmusKjeldgaard linked a pull request Jan 23, 2024 that will close this issue
8 tasks
@rsreimer rsreimer self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants