Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should package discovery be used? #90

Closed
JayyWalker opened this issue Mar 21, 2021 · 2 comments
Closed

Should package discovery be used? #90

JayyWalker opened this issue Mar 21, 2021 · 2 comments
Milestone

Comments

@JayyWalker
Copy link

JayyWalker commented Mar 21, 2021

I've noticed the documentation mentions to add \Eloquence\EloquenceServiceProvider to config/app.php. Most packages use Laravel's automatic package discovery, so it surprised me when this did not show up in the discovered packages list.

Is there a reason why this doesn't use that feature? It's a small amount of work to add so I'm happy to do it if need be.

@kirkbushell
Copy link
Owner

@JayyWalker just never got around to it. Happy to merge any PR that supports auto-discovery :)

@kirkbushell
Copy link
Owner

Coming in 11.0.

@kirkbushell kirkbushell added this to the 11.0 milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants