Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive buttons on @badges page #4

Closed
DRSDavidSoft opened this issue Jan 6, 2019 · 6 comments
Closed

Excessive buttons on @badges page #4

DRSDavidSoft opened this issue Jan 6, 2019 · 6 comments

Comments

@DRSDavidSoft
Copy link

DRSDavidSoft commented Jan 6, 2019

badges-oclb

Since the profile urls have been changed, OCLB displays these buttons on the overhead buttons of the @Badges account.

OCLB/OCLB.user.js

Lines 452 to 453 in 3a195c2

if (window.location.href.endsWith('/badges/')) {
addInCatBar();

Very low priority, but something I thought was worth mentioning.

@KishanBagaria
Copy link
Owner

It's because of

waitForElements(document.body, 'a[href*=".deviantart.com/badges/"], ' + usernameLinkSelector, addLlamaButton);

I added them for dAhub initially but I'm not sure if anyone else uses them. It should be safe to remove them in the next release.

@DRSDavidSoft
Copy link
Author

Interesting, where did dAhub users used them?

@KishanBagaria
Copy link
Owner

The dAhub bot used it for comments it made on the GALGAL group. It was also used on a widget on https://dahub.deviantart.com

@DRSDavidSoft
Copy link
Author

I see; though I always thought you were filtering for /badges/llama, instead.

BTW I'm also returning a link to user badges on GALGAL using dADroid,
so maybe you'd want to keep this for other bots instead of removing it?

In that case, you should rewrite the CSS selector to match the new address, e.g.:

a[href*=".deviantart.com/"][href*="/badges/"]

@KishanBagaria
Copy link
Owner

I suggested using /badges/llama to dAhub but he didn't end up using it. Instead it was always /badges/:id

Right, I'll keep it then.

@KishanBagaria
Copy link
Owner

d23e4e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants