Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much dependency on the prompts for the application to work #2

Closed
jerryjohnjacob opened this issue Jul 8, 2015 · 1 comment
Closed

Comments

@jerryjohnjacob
Copy link

If you look at the line https://github.com/kishore-narendran/AliensOnEarth/blob/master/aliens.js#L50 or https://github.com/kishore-narendran/AliensOnEarth/blob/master/aliens.js#L61, the prompts are governing what the attributes are going to be called.

If there is an error (such as a simple typo in the name of an attribute), the entire application would stop working since there is too much coupling between how the user is prompted to enter data and the actual alien attributes. This needs to change to such a way that the prompts are driven by a data source and not the other way around.

@kishore-narendran
Copy link
Owner

The prompts are now being driven by data source first introduced as a variable in b3f3824 and then shifted to a separate file called alien-parameters.js in 576bdff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants